Surfaceless GLSurfaceOzone implementation.

Surfaceless GLSurfaceOzone implementation.

BUG=380861
NOTRY=true

Committed: https://crrev.com/e79d5d858871272628318f152475cd67aff4f974
Cr-Commit-Position: refs/heads/master@{#292048}

[achaulk, 2014-08-25 21:39:55]

achaulk@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2014-08-26 00:13:21]

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:99: class GL_EXPORT GLSurfaceOzoneSurfaceless : public
SurfacelessEGL {
I'm wondering if you should also override IsOffscreen() and return false?

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:110: if (!ReinitializeNativeSurface() ||
This is mostly a hack for the surface case. On surfaceless we should be able to
cleanly resize the native window. I think we should not do this unless
absolutely necessary.

[achaulk, 2014-08-26 00:35:58]

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:99: class GL_EXPORT GLSurfaceOzoneSurfaceless : public
SurfacelessEGL {
On 2014/08/26 00:13:21, dnicoara wrote:
> I'm wondering if you should also override IsOffscreen() and return false?

Hmm, might be a good idea yeah

https://codereview.chromium.org/498393003/diff/20001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:110: if (!ReinitializeNativeSurface() ||
On 2014/08/26 00:13:21, dnicoara wrote:
> This is mostly a hack for the surface case. On surfaceless we should be able
to
> cleanly resize the native window. I think we should not do this unless
> absolutely necessary.

Sounds good. It was working without all of this, I just added it in case

[dnicoara, 2014-08-26 00:59:16]

lgtm with changes

https://codereview.chromium.org/498393003/diff/40001/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/498393003/diff/40001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:103: const gfx::Size& size)
Drop the size arg and pass in the default value in here.

https://codereview.chromium.org/498393003/diff/40001/ui/gl/gl_surface_ozone.c...
ui/gl/gl_surface_ozone.cc:177: if (!surface->Initialize())
You forgot the VSyncProvider

[achaulk, 2014-08-27 00:14:05]

The CQ bit was checked by achaulk@chromium.org

[commit-bot: I haz the power, 2014-08-27 00:15:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achaulk@chromium.org/498393003/60001

[commit-bot: I haz the power, 2014-08-27 00:17:03]

Committed patchset #4 (60001) as 4b0135573abd706a9c01a03a52ee0de613507991

[commit-bot: I haz the power, 2014-09-10 02:48:01]

Patchset 4 (id:??) landed as
https://crrev.com/e79d5d858871272628318f152475cd67aff4f974
Cr-Commit-Position: refs/heads/master@{#292048}