Surfaceless GLSurfaceOzone implementation.

ui/gl/gl_surface_ozone.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gl/gl_context.h"
@@ skipping 71 matching lines @@
     scoped_ptr<VSyncProvider> vsync_provider =
         ozone_surface_->CreateVSyncProvider();
     if (!Initialize(vsync_provider.Pass())) {
       LOG(ERROR) << "Failed to initialize.";
       return false;
     }
 
     return true;
   }
 
-
   // The native surface. Deleting this is allowed to free the EGLNativeWindow.
   scoped_ptr<ui::SurfaceOzoneEGL> ozone_surface_;
   AcceleratedWidget widget_;
 
   DISALLOW_COPY_AND_ASSIGN(GLSurfaceOzoneEGL);
 };
 
+class GL_EXPORT GLSurfaceOzoneSurfaceless : public SurfacelessEGL {

[dnicoara, 2014/08/26 00:13:21]

I'm wondering if you should also override IsOffscreen() and return false?

[achaulk, 2014/08/26 00:35:58]

Hmm, might be a good idea yeah

+ public:
+  GLSurfaceOzoneSurfaceless(scoped_ptr<ui::SurfaceOzoneEGL> ozone_surface,
+                            AcceleratedWidget widget,
+                            const gfx::Size& size)
+      : SurfacelessEGL(size),
+        ozone_surface_(ozone_surface.Pass()),
+        widget_(widget) {}
+
+  virtual bool Resize(const gfx::Size& size) OVERRIDE {
+    if (!ozone_surface_->ResizeNativeWindow(size)) {
+      if (!ReinitializeNativeSurface() ||

[dnicoara, 2014/08/26 00:13:21]

This is mostly a hack for the surface case. On surfaceless we should be able to
cleanly resize the native window. I think we should not do this unless
absolutely necessary.

[achaulk, 2014/08/26 00:35:58]

Sounds good. It was working without all of this, I just added it in case

+          !ozone_surface_->ResizeNativeWindow(size))
+        return false;
+    }
+
+    return SurfacelessEGL::Resize(size);
+  }
+  virtual bool SwapBuffers() OVERRIDE {
+    return ozone_surface_->OnSwapBuffers();
+  }
+  virtual bool ScheduleOverlayPlane(int z_order,
+                                    OverlayTransform transform,
+                                    GLImage* image,
+                                    const Rect& bounds_rect,
+                                    const RectF& crop_rect) OVERRIDE {
+    return image->ScheduleOverlayPlane(
+        widget_, z_order, transform, bounds_rect, crop_rect);
+  }
+
+ private:
+  bool ReinitializeNativeSurface() {
+    scoped_ptr<ui::ScopedMakeCurrent> scoped_make_current;
+    GLContext* current_context = GLContext::GetCurrent();
+    bool was_current = current_context && current_context->IsCurrent(this);
+    if (was_current) {
+      scoped_make_current.reset(
+          new ui::ScopedMakeCurrent(current_context, this));
+    }
+
+    Destroy();
+    ozone_surface_ = ui::SurfaceFactoryOzone::GetInstance()
+                         ->CreateSurfacelessEGLSurfaceForWidget(widget_)
+                         .Pass();
+    if (!ozone_surface_) {
+      LOG(ERROR) << "Failed to create native surface.";
+      return false;
+    }
+
+    if (!Initialize()) {
+      LOG(ERROR) << "Failed to initialize.";
+      return false;
+    }
+
+    return true;
+  }
+
+  // The native surface. Deleting this is allowed to free the EGLNativeWindow.
+  scoped_ptr<ui::SurfaceOzoneEGL> ozone_surface_;
+  AcceleratedWidget widget_;
+
+  DISALLOW_COPY_AND_ASSIGN(GLSurfaceOzoneSurfaceless);
+};
+
 }  // namespace
 
 // static
 bool GLSurface::InitializeOneOffInternal() {
   switch (GetGLImplementation()) {
     case kGLImplementationEGLGLES2:
       if (!GLSurfaceEGL::InitializeOneOff()) {
         LOG(ERROR) << "GLSurfaceEGL::InitializeOneOff failed.";
         return false;
       }
@@ skipping 11 matching lines @@
 scoped_refptr<GLSurface> GLSurface::CreateViewGLSurface(
     gfx::AcceleratedWidget window) {
   if (GetGLImplementation() == kGLImplementationOSMesaGL) {
     scoped_refptr<GLSurface> surface(new GLSurfaceOSMesaHeadless());
     if (!surface->Initialize())
       return NULL;
     return surface;
   }
   DCHECK(GetGLImplementation() == kGLImplementationEGLGLES2);
   if (window != kNullAcceleratedWidget) {
+    if (GLSurfaceEGL::IsEGLSurfacelessContextSupported() &&
+        ui::SurfaceFactoryOzone::GetInstance()
+            ->CanShowPrimaryPlaneAsOverlay()) {
+      scoped_ptr<ui::SurfaceOzoneEGL> surface_ozone =
+          ui::SurfaceFactoryOzone::GetInstance()
+              ->CreateSurfacelessEGLSurfaceForWidget(window);
+      if (!surface_ozone)
+        return NULL;
+      scoped_refptr<GLSurfaceOzoneSurfaceless> surface =
+          new GLSurfaceOzoneSurfaceless(
+              surface_ozone.Pass(), window, gfx::Size());
+      if (!surface->Initialize())
+        return NULL;
+      return surface;
+    }
     scoped_ptr<ui::SurfaceOzoneEGL> surface_ozone =
         ui::SurfaceFactoryOzone::GetInstance()->CreateEGLSurfaceForWidget(
             window);
     if (!surface_ozone)
       return NULL;
 
     scoped_ptr<VSyncProvider> vsync_provider =
         surface_ozone->CreateVSyncProvider();
     scoped_refptr<GLSurfaceOzoneEGL> surface =
         new GLSurfaceOzoneEGL(surface_ozone.Pass(), window);
@@ skipping 36 matching lines @@
       NOTREACHED();
       return NULL;
   }
 }
 
 EGLNativeDisplayType GetPlatformDefaultEGLNativeDisplay() {
   return ui::SurfaceFactoryOzone::GetInstance()->GetNativeDisplay();
 }
 
 }  // namespace gfx