Issue 498393002: Windows fixes for GN build.

Issue 498393002: Windows fixes for GN build. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Committed: https://crrev.com/0ab2c722a1bad95a2748dbc3911c742dc04828db Cr-Commit-Position: refs/heads/master@{#291749}

Patch Set 2 : fix slash #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
M	chrome/BUILD.gn	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/BUILD.gn	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/498393002/diff/1/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/498393002/diff/1/third_party/libjingle/BUILD.gn#newcode259 third_party/libjingle/BUILD.gn:259: cflags = [ "/wd4005", "\wd4267" ] why the ...

6 years, 4 months ago (2014-08-25 19:40:55 UTC) #2

brettw

https://codereview.chromium.org/498393002/diff/1/third_party/libjingle/BUILD.gn File third_party/libjingle/BUILD.gn (right): https://codereview.chromium.org/498393002/diff/1/third_party/libjingle/BUILD.gn#newcode259 third_party/libjingle/BUILD.gn:259: cflags = [ "/wd4005", "\wd4267" ] On 2014/08/25 19:40:55, ...

6 years, 4 months ago (2014-08-25 19:42:40 UTC) #3

brettw

Committed patchset #2 to pending queue manually as 17fce25.

6 years, 3 months ago (2014-08-25 20:16:54 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:37:07 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/0ab2c722a1bad95a2748dbc3911c742dc04828db
Cr-Commit-Position: refs/heads/master@{#291749}

Expand Messages | Collapse Messages