chrome/BUILD.gn - Issue 498393002: Windows fixes for GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 498393002: Windows fixes for GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix slash Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 00284f6c86349c52f74650bbe6cfb20b27bc698d..dc1444eb4e9a7347d28519635083468dbb2d734f 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -114,7 +114,7 @@ shared_library("main_dll") {

"//chrome/app/theme:chrome_unscaled_resources",

"//content/app/resources",

"//crypto",

- "//net:resources",

+ "//net:net_resources",

"//third_party/wtl",

"//ui/views",

#'<(DEPTH)/chrome_elf/chrome_elf.gyp:chrome_elf' ] TODO(GYP)

@@ -212,7 +212,9 @@ if (is_win) {

# TODO(brettw) this duplicates "//chrome/common:version" which applies to

# Linux.

process_version("version_header") {

- visibility = ":*"

+ # TODO(brettW) this should have more reduced visibility, but chrome/browser

+ # currently depends on this.

+ #visibility = ":*"

source = "version.h.in"

# TODO(brettw) this should move to $target_gen_dir/version.h and

# source files including it should reference it via "chrome/version.h"

« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »