Disable Channel ID

Disable Channel ID

BUG=406854
Bug: b/17177684

Enabling channel ID causes problems for apps that use multiple network
stacks (such as httpurlconnection and webview) or multiple webviews
and want to share cookies. Disable until we provide some solution.

Committed: https://crrev.com/3197cce8af19aca297a9acd3a8b8c75c8d64e9cf
Cr-Commit-Position: refs/heads/master@{#291610}

[sgurun-gerrit only, 2014-08-23 16:09:40]

rsleevi PTAL as a net owner.
boliu need owner's stamp after rsleevi's review

[boliu, 2014-08-23 16:35:58]

you are an owner now, no need for me to stamp things :)

https://codereview.chromium.org/497963002/diff/1/android_webview/browser/net/...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/497963002/diff/1/android_webview/browser/net/...
android_webview/browser/net/aw_url_request_context_getter.cc:212: // See
b/17177684
nit: we generally don't put internal bugs into chormium source or CL
descriptions. File a crbug which can refer to an internal bug, or in this case,
I don't even think it needs one

[sgurun-gerrit only, 2014-08-23 17:44:59]

On 2014/08/23 16:35:58, boliu wrote:
> you are an owner now, no need for me to stamp things :)

I guess. though then I miss the nit below 

> 
>
https://codereview.chromium.org/497963002/diff/1/android_webview/browser/net/...
> File android_webview/browser/net/aw_url_request_context_getter.cc (right):
> 
>
https://codereview.chromium.org/497963002/diff/1/android_webview/browser/net/...
> android_webview/browser/net/aw_url_request_context_getter.cc:212: // See
> b/17177684
> nit: we generally don't put internal bugs into chormium source or CL
> descriptions. File a crbug which can refer to an internal bug, or in this
case,
> I don't even think it needs one

[Ryan Sleevi, 2014-08-23 17:57:16]

Delete the code. Don't use #ifdefs like this.

Otherwise LGTM as the right way to disable.

[sgurun-gerrit only, 2014-08-23 18:06:47]

ok deleted all :)

[sgurun-gerrit only, 2014-08-23 18:07:29]

lgtm as rsleevi is already ok'ed

[sgurun-gerrit only, 2014-08-23 18:07:38]

On 2014/08/23 18:07:29, sgurun wrote:
> lgtm as rsleevi is already ok'ed

LGTM

[sgurun-gerrit only, 2014-08-23 18:09:31]

LGTM  :)

[boliu, 2014-08-23 18:09:39]

On 2014/08/23 18:07:38, sgurun wrote:
> On 2014/08/23 18:07:29, sgurun wrote:
> > lgtm as rsleevi is already ok'ed
> 
> LGTM

this ain't gerrit, can't approve your own CLs, and you don't need to, cq won't
complain now

although I still see b/ link in description

[sgurun-gerrit only, 2014-08-23 18:11:08]

On 2014/08/23 18:09:39, boliu wrote:
> On 2014/08/23 18:07:38, sgurun wrote:
> > On 2014/08/23 18:07:29, sgurun wrote:
> > > lgtm as rsleevi is already ok'ed
> > 
> > LGTM
> 
> this ain't gerrit, can't approve your own CLs, and you don't need to, cq won't
> complain now
> 
> although I still see b/ link in description

we always put b/ 's in cl's but yeah never lgtm'ed something mine so surprise
surprise to me. :)

[sgurun-gerrit only, 2014-08-23 18:11:28]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2014-08-23 18:12:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sgurun@chromium.org/497963002/20001

[sgurun-gerrit only, 2014-08-23 18:19:57]

The CQ bit was unchecked by sgurun@chromium.org

[sgurun-gerrit only, 2014-08-23 18:21:46]

On 2014/08/23 18:19:57, sgurun wrote:
> The CQ bit was unchecked by mailto:sgurun@chromium.org

let's add a bug number, since we will need to merge to M38, which I forgot.

[sgurun-gerrit only, 2014-08-23 18:28:31]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2014-08-23 18:30:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sgurun@chromium.org/497963002/30001

[commit-bot: I haz the power, 2014-08-23 19:23:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-23 22:26:09]

Committed patchset #3 (30001) as e1a19465017e9c23460d01dcf644ba50fa6a210c

[commit-bot: I haz the power, 2014-09-10 02:32:10]

Patchset 3 (id:??) landed as
https://crrev.com/3197cce8af19aca297a9acd3a8b8c75c8d64e9cf
Cr-Commit-Position: refs/heads/master@{#291610}