Bounds check in CFX_Font::LoadGlyphPath().

Bounds check in CFX_Font::LoadGlyphPath().

Add a check to CFX_Font::LoadGlyphPath() similar to the one that exists
in CFX_FaceCache::RenderGlyph().

Also replace some scattered magic numbers in the file with constants,
and make arrays not used outside this file be statically scoped.

BUG=406144
R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/02132dc

[Tom Sepez, 2014-08-22 22:07:56]

Jun, please review.

[jun_fang, 2014-08-22 22:42:13]

Hi Tom, please see my comments.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
File core/src/fxge/ge/fx_ge_text.cpp (right):

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1229: #define ANGLESKEW_ARRAY_SIZE 30
Is it better to use a 'const variable' like:
const size_t ANGLESKEW_ARRAY_SIZE = 30;

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1235: #define WEIGHTPOW_ARRAY_SIZE 100
The same comment as the previous one.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1328: skew = skew <= -ANGLESKEW_ARRAY_SIZE ? -58
: -g_AngleSkew[-skew];
Do we need to check |if (skew <= 0)|?

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1354: int index = (weight - 400) / 10;
check |index < 0|?

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1640: skew = skew <= -ANGLESKEW_ARRAY_SIZE ? -58
: -g_AngleSkew[-skew];
The same as line 1328.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1660: int index = (m_pSubstFont->m_Weight - 400)
/ 10;
do we need to check |if (index < 0)|?

[Tom Sepez, 2014-08-22 23:02:33]

I changed the #defines to const size_t's.  Let me know if you care about the
other issues, and I'll address them.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
File core/src/fxge/ge/fx_ge_text.cpp (right):

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1229: #define ANGLESKEW_ARRAY_SIZE 30
On 2014/08/22 22:42:12, jun_fang wrote:
> Is it better to use a 'const variable' like:
> const size_t ANGLESKEW_ARRAY_SIZE = 30;

Done.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1235: #define WEIGHTPOW_ARRAY_SIZE 100
On 2014/08/22 22:42:12, jun_fang wrote:
> The same comment as the previous one.

Done.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1328: skew = skew <= -ANGLESKEW_ARRAY_SIZE ? -58
: -g_AngleSkew[-skew];
On 2014/08/22 22:42:12, jun_fang wrote:
> Do we need to check |if (skew <= 0)|?

Probably.  But I'd like to save that for another day.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1354: int index = (weight - 400) / 10;
On 2014/08/22 22:42:13, jun_fang wrote:
> check |index < 0|?
We could, but we just checked weight > 400 as part of the if above.  I'd assume
that covers it.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1640: skew = skew <= -ANGLESKEW_ARRAY_SIZE ? -58
: -g_AngleSkew[-skew];
On 2014/08/22 22:42:12, jun_fang wrote:
> The same as line 1328.
Again, for another day.

https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
core/src/fxge/ge/fx_ge_text.cpp:1660: int index = (m_pSubstFont->m_Weight - 400)
/ 10;
On 2014/08/22 22:42:12, jun_fang wrote:
> do we need to check |if (index < 0)|?

Same deal wiht checking > 400 in the if above.

[jun_fang, 2014-08-22 23:05:57]

On 2014/08/22 23:02:33, Tom Sepez wrote:
> I changed the #defines to const size_t's.  Let me know if you care about the
> other issues, and I'll address them.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> File core/src/fxge/ge/fx_ge_text.cpp (right):
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1229: #define ANGLESKEW_ARRAY_SIZE 30
> On 2014/08/22 22:42:12, jun_fang wrote:
> > Is it better to use a 'const variable' like:
> > const size_t ANGLESKEW_ARRAY_SIZE = 30;
> 
> Done.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1235: #define WEIGHTPOW_ARRAY_SIZE 100
> On 2014/08/22 22:42:12, jun_fang wrote:
> > The same comment as the previous one.
> 
> Done.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1328: skew = skew <= -ANGLESKEW_ARRAY_SIZE ?
-58
> : -g_AngleSkew[-skew];
> On 2014/08/22 22:42:12, jun_fang wrote:
> > Do we need to check |if (skew <= 0)|?
> 
> Probably.  But I'd like to save that for another day.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1354: int index = (weight - 400) / 10;
> On 2014/08/22 22:42:13, jun_fang wrote:
> > check |index < 0|?
> We could, but we just checked weight > 400 as part of the if above.  I'd
assume
> that covers it.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1640: skew = skew <= -ANGLESKEW_ARRAY_SIZE ?
-58
> : -g_AngleSkew[-skew];
> On 2014/08/22 22:42:12, jun_fang wrote:
> > The same as line 1328.
> Again, for another day.
> 
>
https://codereview.chromium.org/497863002/diff/80001/core/src/fxge/ge/fx_ge_t...
> core/src/fxge/ge/fx_ge_text.cpp:1660: int index = (m_pSubstFont->m_Weight -
400)
> / 10;
> On 2014/08/22 22:42:12, jun_fang wrote:
> > do we need to check |if (index < 0)|?
> 
> Same deal wiht checking > 400 in the if above.

Thanks. LGTM.

[Tom Sepez, 2014-08-22 23:08:01]

Committed patchset #6 manually as 02132dc (presubmit successful).