Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.cc

Issue 497843002: GuestViews should be able to specify task manager entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/app_view/app_view_guest.cc
diff --git a/extensions/browser/guest_view/app_view/app_view_guest.cc b/extensions/browser/guest_view/app_view/app_view_guest.cc
index 9b82badfe1508ed2d3819d1a650d5e013db5ffe5..8eda024e959502f37d4b26a3bed02223b2c586d0 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest.cc
+++ b/extensions/browser/guest_view/app_view/app_view_guest.cc
@@ -102,7 +102,7 @@ AppViewGuest::AppViewGuest(content::BrowserContext* browser_context,
int guest_instance_id)
: GuestView<AppViewGuest>(browser_context, guest_instance_id),
app_view_guest_delegate_(
- ExtensionsAPIClient::Get()->CreateAppViewGuestDelegate()),
+ ExtensionsAPIClient::Get()->CreateAppViewGuestDelegate(this)),
weak_ptr_factory_(this) {
}
@@ -134,10 +134,16 @@ bool AppViewGuest::HandleContextMenu(const content::ContextMenuParams& params) {
return false;
}
-const char* AppViewGuest::GetAPINamespace() {
+const char* AppViewGuest::GetAPINamespace() const {
return appview::kEmbedderAPINamespace;
}
+int AppViewGuest::GetTaskPrefix() const {
+ if (!app_view_guest_delegate_)
+ return 0;
Charlie Reis 2014/08/25 20:25:41 Maybe IDS_TASK_MANAGER_APPVIEW_TAG_PREFIX by defau
Fady Samuel 2014/08/25 23:05:52 Done.
+ return app_view_guest_delegate_->GetTaskPrefix();
+}
+
void AppViewGuest::CreateWebContents(
const std::string& embedder_extension_id,
int embedder_render_process_id,

Powered by Google App Engine
This is Rietveld 408576698