GuestViews should be able to specify task manager entries

extensions/browser/guest_view/app_view/app_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
 
 #include "base/command_line.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/renderer_preferences.h"
 #include "extensions/browser/api/app_runtime/app_runtime_api.h"
@@ skipping 84 matching lines @@
       extensions::switches::kEnableAppView)) {
     return NULL;
   }
   return new AppViewGuest(browser_context, guest_instance_id);
 }
 
 AppViewGuest::AppViewGuest(content::BrowserContext* browser_context,
                            int guest_instance_id)
     : GuestView<AppViewGuest>(browser_context, guest_instance_id),
       app_view_guest_delegate_(
-          ExtensionsAPIClient::Get()->CreateAppViewGuestDelegate()),
+          ExtensionsAPIClient::Get()->CreateAppViewGuestDelegate(this)),
       weak_ptr_factory_(this) {
 }
 
 AppViewGuest::~AppViewGuest() {
 }
 
 WindowController* AppViewGuest::GetExtensionWindowController() const {
   return NULL;
 }
 
@@ skipping 11 matching lines @@
 }
 
 bool AppViewGuest::HandleContextMenu(const content::ContextMenuParams& params) {
   if (app_view_guest_delegate_) {
     return app_view_guest_delegate_->HandleContextMenu(guest_web_contents(),
                                                        params);
   }
   return false;
 }
 
-const char* AppViewGuest::GetAPINamespace() {
+const char* AppViewGuest::GetAPINamespace() const {
   return appview::kEmbedderAPINamespace;
 }
 
+int AppViewGuest::GetTaskPrefix() const {
+  if (!app_view_guest_delegate_)
+    return 0;

[Charlie Reis, 2014/08/25 20:25:41]

Maybe IDS_TASK_MANAGER_APPVIEW_TAG_PREFIX by default?

[Fady Samuel, 2014/08/25 23:05:52]

Done.

+  return app_view_guest_delegate_->GetTaskPrefix();
+}
+
 void AppViewGuest::CreateWebContents(
     const std::string& embedder_extension_id,
     int embedder_render_process_id,
     const base::DictionaryValue& create_params,
     const WebContentsCreatedCallback& callback) {
   std::string app_id;
   if (!create_params.GetString(appview::kAppID, &app_id)) {
     callback.Run(NULL);
     return;
   }
@@ skipping 97 matching lines @@
 
   scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue());
   embed_request->SetInteger(appview::kGuestInstanceID, guest_instance_id());
   embed_request->SetString(appview::kEmbedderID, embedder_extension_id());
   embed_request->Set(appview::kData, data.release());
   AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(
       browser_context(), embed_request.Pass(), extension_host->extension());
 }
 
 }  // namespace extensions