Declaring the weak_ptr_factory in proper order.

ash/wm/workspace/workspace_window_resizer.h

Index: ash/wm/workspace/workspace_window_resizer.h
diff --git a/ash/wm/workspace/workspace_window_resizer.h b/ash/wm/workspace/workspace_window_resizer.h
index 99a2df51cd967c4608d92ad73613829f3b7c3e27..2d254911d5959a2425288f58577b1076b7974e13 100644
--- a/ash/wm/workspace/workspace_window_resizer.h
+++ b/ash/wm/workspace/workspace_window_resizer.h
@@ -167,6 +167,9 @@ class ASH_EXPORT WorkspaceWindowResizer : public WindowResizer {
 
   const std::vector<aura::Window*> attached_windows_;
 
+  // Adding method to return WorkspaceWindowResizer *instance

[oshima, 2014/09/04 06:18:48]

// Returns the currently used instance for test.

[Anand Ratn (left samsung), 2014/09/04 07:31:12]

Done.

+  static WorkspaceWindowResizer* g_instance();

[oshima, 2014/09/04 06:18:48]

Sorry I meant "g_instance "as variable name. (It's pretty common among chromium
developers, but I should not have expected that)

On second thought, it's probably better to call it "GetInstanceForTest()".

Let me be very specific this time to avoid confusion this time.

Method:

static WorkspaceWindowResizer* GetInstanceForTest();

variable:

WorkspaceWindowResizer* instance = NULL;

in anonymous namespace in the file "workspace_window_resizer.cc"

[Anand Ratn (left samsung), 2014/09/04 07:31:12]

Thank you oshima for clearing my doubt . I have made the changes accordingly in
new patchset.

+
   bool did_lock_cursor_;
 
   // Set to true once Drag() is invoked and the bounds of the window change.
@@ -221,9 +224,6 @@ class ASH_EXPORT WorkspaceWindowResizer : public WindowResizer {
   // gets dragged into another browser window.
   base::WeakPtrFactory<WorkspaceWindowResizer> weak_ptr_factory_;
 
-  // Current instance for use by the WorkspaceWindowResizerTest.
-  static WorkspaceWindowResizer* instance_;
-
   DISALLOW_COPY_AND_ASSIGN(WorkspaceWindowResizer);
 };