Declaring the weak_ptr_factory in proper order.

ash/wm/workspace/workspace_window_resizer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 #define ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 
 #include <vector>
 
 #include "ash/wm/window_resizer.h"
@@ skipping 149 matching lines @@
   bool AreBoundsValidSnappedBounds(wm::WindowStateType snapped_type,
                                    const gfx::Rect& bounds_in_parent) const;
 
   // Docks or undocks the dragged window.
   void SetDraggedWindowDocked(bool should_dock);
 
   wm::WindowState* window_state() { return window_state_; }
 
   const std::vector<aura::Window*> attached_windows_;
 
+  // Adding method to return WorkspaceWindowResizer *instance

[oshima, 2014/09/04 06:18:48]

// Returns the currently used instance for test.

[Anand Ratn (left samsung), 2014/09/04 07:31:12]

Done.

+  static WorkspaceWindowResizer* g_instance();

[oshima, 2014/09/04 06:18:48]

Sorry I meant "g_instance "as variable name. (It's pretty common among chromium
developers, but I should not have expected that)

On second thought, it's probably better to call it "GetInstanceForTest()".

Let me be very specific this time to avoid confusion this time.

Method:

static WorkspaceWindowResizer* GetInstanceForTest();

variable:

WorkspaceWindowResizer* instance = NULL;

in anonymous namespace in the file "workspace_window_resizer.cc"

[Anand Ratn (left samsung), 2014/09/04 07:31:12]

Thank you oshima for clearing my doubt . I have made the changes accordingly in
new patchset.

+
   bool did_lock_cursor_;
 
   // Set to true once Drag() is invoked and the bounds of the window change.
   bool did_move_or_resize_;
 
   // True if the window initially had |bounds_changed_by_user_| set in state.
   bool initial_bounds_changed_by_user_;
 
   // The initial size of each of the windows in |attached_windows_| along the
   // primary axis.
@@ skipping 34 matching lines @@
   // should attach.
   MatchedEdge magnetism_edge_;
 
   // Dock container window layout manager.
   DockedWindowLayoutManager* dock_layout_;
 
   // Used to determine if this has been deleted during a drag such as when a tab
   // gets dragged into another browser window.
   base::WeakPtrFactory<WorkspaceWindowResizer> weak_ptr_factory_;
 
-  // Current instance for use by the WorkspaceWindowResizerTest.
-  static WorkspaceWindowResizer* instance_;
-
   DISALLOW_COPY_AND_ASSIGN(WorkspaceWindowResizer);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_WORKSPACE_WINDOW_RESIZER_H_