Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 497693002: Revert 291359 "Hide PopupZoomer when the container view or windo..." (Closed)

Created:
6 years, 4 months ago by Finnur
Modified:
6 years, 4 months ago
Reviewers:
raghu
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 291359 "Hide PopupZoomer when the container view or windo..." It caused a failure on Android bot: ******************************************************************************** New warnings. Please fix, or perhaps add to /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt -------------------------------------------------------------------------------- M C IJU: TestCase org.chromium.content.browser.PopupZoomerTest defines setUp that doesn't call super.setUp() At PopupZoomerTest.java -------------------------------------------------------------------------------- Original patch comments: > Hide PopupZoomer when the container view or window loses focus > > Currently there is a method which hides all the popups but call to > hide PopupZoomer is missing. Added the call to hide PopupZoomer inside > hidePopups and hiding the zoomer when the view loses focus or the > window loses focus. Also added unit test code. > > BUG=405477 > > Review URL: https://codereview.chromium.org/470193005 TBR=r.ghatage@samsung.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -38 lines) Patch
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 4 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 3 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
6 years, 4 months ago (2014-08-22 09:31:52 UTC) #1
Finnur
6 years, 4 months ago (2014-08-22 09:32:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r291365 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698