Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 497693002: Revert 291359 "Hide PopupZoomer when the container view or windo..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
===================================================================
--- trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (revision 291364)
+++ trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (working copy)
@@ -521,7 +521,9 @@
new ImeAdapter.ImeAdapterDelegate() {
@Override
public void onImeEvent() {
- mPopupZoomer.hide(true);
+ if (mPopupZoomer.isShowing()) {
+ mPopupZoomer.hide(true);
+ }
getContentViewClient().onImeEvent();
hideTextHandles();
}
@@ -752,11 +754,6 @@
mPopupZoomer.setOnTapListener(listener);
}
- @VisibleForTesting
- public void setPopupZoomerForTest(PopupZoomer popupZoomer) {
- mPopupZoomer = popupZoomer;
- }
-
/**
* Destroy the internal state of the ContentView. This method may only be
* called after the ContentView has been removed from the view system. No
@@ -1433,7 +1430,6 @@
hidePastePopup();
hideSelectPopup();
hideTextHandles();
- mPopupZoomer.hide(false);
}
public void hideSelectActionBar() {
@@ -1627,7 +1623,6 @@
cancelRequestToScrollFocusedEditableNodeIntoView();
hidePastePopup();
hideTextHandles();
- mPopupZoomer.hide(false);
}
if (mNativeContentViewCore != 0) nativeSetFocus(mNativeContentViewCore, gainFocus);
}
« no previous file with comments | « no previous file | trunk/src/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698