Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 497673002: [fsp] Do not allow to cancel closing a file. (Closed)

Created:
6 years, 4 months ago by mtomasz
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Do not allow to cancel closing a file. Closing a file should not be abortable, since we could end up on files which once opened, are never closed. TEST=browser_tests: *FileSystemProvider*WriteFile* BUG=405821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@hirono: PTAL at this trivial patch. Thanks.
6 years, 4 months ago (2014-08-22 06:25:35 UTC) #1
hirono
lgtm!
6 years, 4 months ago (2014-08-22 06:45:34 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 4 months ago (2014-08-22 08:09:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/497673002/1
6 years, 4 months ago (2014-08-22 08:10:22 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-22 09:11:32 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 10:43:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 291381

Powered by Google App Engine
This is Rietveld 408576698