[fsp] Do not allow to cancel closing a file.

chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer.h"
 
 #include "base/debug/trace_event.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h"
 #include "chrome/browser/chromeos/file_system_provider/mount_path_util.h"
@@ skipping 41 matching lines @@
         ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE,
         base::Bind(
             &OperationRunner::OnOpenFileCompletedOnUIThread, this, callback));
   }
 
   // Closes a file. Ignores result, since outlives the caller. Must be called on
   // UI thread.
   void CloseFileOnUIThread() {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
     if (file_system_.get() && file_handle_ != -1) {
-      abort_callback_ = file_system_->CloseFile(
-          file_handle_, base::Bind(&EmptyStatusCallback));
+      // Closing a file must not be aborted, since we could end up on files
+      // which are never closed.
+      file_system_->CloseFile(file_handle_, base::Bind(&EmptyStatusCallback));
+      abort_callback_ = ProvidedFileSystemInterface::AbortCallback();
     }
   }
 
   // Requests writing bytes to the file. In case of either success or a failure
   // |callback| is executed. Must be called on UI thread.
   void WriteFileOnUIThread(
       scoped_refptr<net::IOBuffer> buffer,
       int64 offset,
       int length,
       const fileapi::AsyncFileUtil::StatusCallback& callback) {
@@ skipping 15 matching lines @@
         length,
         base::Bind(
             &OperationRunner::OnWriteFileCompletedOnUIThread, this, callback));
   }
 
   // Aborts the most recent operation (if exists), and calls the callback.
   void AbortOnUIThread(const fileapi::AsyncFileUtil::StatusCallback& callback) {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
     if (abort_callback_.is_null()) {
-      // No operation on the file system being performed. At most a callback
-      // call, which will be discarded.
-      BrowserThread::PostTask(
-          BrowserThread::IO,
-          FROM_HERE,
-          base::Bind(callback, base::File::FILE_ERROR_ABORT));
+      // No operation to be cancelled. At most a callback call, which will be
+      // discarded.
+      BrowserThread::PostTask(BrowserThread::IO,
+                              FROM_HERE,
+                              base::Bind(callback, base::File::FILE_OK));
       return;
     }
 
     const ProvidedFileSystemInterface::AbortCallback abort_callback =
         abort_callback_;
     abort_callback_ = ProvidedFileSystemInterface::AbortCallback();
     abort_callback.Run(base::Bind(
         &OperationRunner::OnAbortCompletedOnUIThread, this, callback));
   }
 
@@ skipping 214 matching lines @@
                  current_offset_,
                  buffer_length,
                  base::Bind(&FileStreamWriter::OnWriteFileCompleted,
                             weak_ptr_factory_.GetWeakPtr(),
                             buffer_length,
                             callback)));
 }
 
 }  // namespace file_system_provider
 }  // namespace chromeos