Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.h

Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Profile * ----> Profile* Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.h
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.h b/chrome/browser/bookmarks/enhanced_bookmarks_features.h
index afd2473cecede597048c11ed1904537a3f73d150..a8ee358b7150aede6febbaf9019414da5134fe42 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.h
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.h
@@ -43,12 +43,20 @@ void ForceFinchBookmarkExperimentIfNeeded(
PrefService* local_state,
BookmarksExperimentState bookmarks_experiment_state);
-// Returns true if enhanced bookmarks experiment is enabled.
-// Experiment could be enable from Chrome sync or from Finch.
+// Returns true if enhanced bookmarks experiment is running.
+// Experiment could run by Chrome sync or by Finch.
+// Note that this doesn't necessarily mean that enhanced bookmarks
+// is enabled, e.g., user can opt out using a flag.
bool IsEnhancedBookmarksExperimentEnabled();
#if defined(OS_ANDROID)
-bool IsEnhancedBookmarkImageFetchingEnabled();
+// Returns true if enhanced bookmark salient image prefetching is enabled.
+// This can be controlled by field trial.
+bool IsEnhancedBookmarkImageFetchingEnabled(const PrefService* user_prefs);
+
+// Returns true if enhanced bookmarks is enabled.
+bool IsEnhancedBookmarksEnabled(const PrefService* user_prefs);
+
#endif
// Returns true when flag enable-dom-distiller is set or enabled from Finch.

Powered by Google App Engine
This is Rietveld 408576698