Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 497563002: [Android] Use correct enhanced bookmarks enabling logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Profile * ----> Profile* Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index aad3817e1bcacbf3786729c87ccb50b76c88132b..aa7b7b7faeb42aa543dfb78abb39608e1130c7b8 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -179,8 +179,8 @@ bool IsEnhancedBookmarksExperimentEnabled() {
}
#if defined(OS_ANDROID)
-bool IsEnhancedBookmarkImageFetchingEnabled() {
- if (IsEnhancedBookmarksExperimentEnabled())
+bool IsEnhancedBookmarkImageFetchingEnabled(const PrefService* user_prefs) {
+ if (IsEnhancedBookmarksEnabled(user_prefs))
return true;
// Salient images are collected from visited bookmarked pages even if the
@@ -192,6 +192,14 @@ bool IsEnhancedBookmarkImageFetchingEnabled() {
kFieldTrialName, "DisableImagesFetching");
return disable_fetching.empty();
}
+
+bool IsEnhancedBookmarksEnabled(const PrefService* user_prefs) {
+ BookmarksExperimentState bookmarks_experiment_state =
+ static_cast<BookmarksExperimentState>(user_prefs->GetInteger(
+ sync_driver::prefs::kEnhancedBookmarksExperimentEnabled));
+ return bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_ENABLED
+ || bookmarks_experiment_state == BOOKMARKS_EXPERIMENT_ENABLED_FROM_FINCH;
sky 2014/09/03 21:26:20 nit: I believe style guide says || should be on pr
Kibeom Kim (inactive) 2014/09/03 21:32:22 Done.
+}
#endif
bool IsEnableDomDistillerSet() {
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698