RAPPOR implementation

components/variations/metrics_util.h

Index: components/variations/metrics_util.h
diff --git a/components/variations/metrics_util.h b/components/variations/metrics_util.h
index b331d4eaf1f3e9d252398c5180c0f1319c818341..f0c42daa2bb7cc5fb83352d713f15d11318241ba 100644
--- a/components/variations/metrics_util.h
+++ b/components/variations/metrics_util.h
@@ -15,6 +15,10 @@ namespace metrics {
 // uniquely identifying field trial names and group names.
 uint32 HashName(const std::string& name);

[Ilya Sherman, 2014/02/12 23:25:59]

nit: This method should probably be renamed to something more specific, if it is
going to be a sibling of one called HashMetricName().

[Steven Holte, 2014/02/13 05:11:12]

I'd rather leave that for a more focused cleanup of the variations/metrics
dependencies.

[Ilya Sherman, 2014/02/13 23:23:08]

You're welcome to split off the cleanup to a separate CL that you land first --
in fact, I'd encourage that -- but please don't land a CL that leaves this code
in a known bad state.  While I trust that your intentions are good, it's easy to
lose track of low-priority maintenance tasks, which builds up over time.  Thus,
I'm asking you to do this cleanup now, rather than punting it.

 
+// Computes a uint64 hash of a given string based on its MD5 hash. Suitable for
+// metric names.
+uint64 HashMetricName(const std::string& name);
+
 }  // namespace metrics
 
 #endif  // COMPONENTS_VARIATIONS_METRICS_UTIL_H_