components/variations/metrics_util.h - Issue 49753002: RAPPOR implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/variations/metrics_util.h

Issue 49753002: RAPPOR implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_VARIATIONS_METRICS_UTIL_H_	5 #ifndef COMPONENTS_VARIATIONS_METRICS_UTIL_H_

6 #define COMPONENTS_VARIATIONS_METRICS_UTIL_H_	6 #define COMPONENTS_VARIATIONS_METRICS_UTIL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

11	11

12 namespace metrics {	12 namespace metrics {

13	13

14 // Computes a uint32 hash of a given string based on its SHA1 hash. Suitable for	14 // Computes a uint32 hash of a given string based on its SHA1 hash. Suitable for

15 // uniquely identifying field trial names and group names.	15 // uniquely identifying field trial names and group names.

16 uint32 HashName(const std::string& name);	16 uint32 HashName(const std::string& name);
	Ilya Sherman 2014/02/12 23:25:59 nit: This method should probably be renamed to som nit: This method should probably be renamed to something more specific, if it is going to be a sibling of one called HashMetricName(). Steven Holte 2014/02/13 05:11:12 I'd rather leave that for a more focused cleanup o Show quoted text On 2014/02/12 23:25:59, Ilya Sherman wrote: > nit: This method should probably be renamed to something more specific, if it is > going to be a sibling of one called HashMetricName(). I'd rather leave that for a more focused cleanup of the variations/metrics dependencies. Ilya Sherman 2014/02/13 23:23:08 You're welcome to split off the cleanup to a separ Show quoted text On 2014/02/13 05:11:12, Steven Holte wrote: > On 2014/02/12 23:25:59, Ilya Sherman wrote: > > nit: This method should probably be renamed to something more specific, if it > is > > going to be a sibling of one called HashMetricName(). > > I'd rather leave that for a more focused cleanup of the variations/metrics > dependencies. You're welcome to split off the cleanup to a separate CL that you land first -- in fact, I'd encourage that -- but please don't land a CL that leaves this code in a known bad state. While I trust that your intentions are good, it's easy to lose track of low-priority maintenance tasks, which builds up over time. Thus, I'm asking you to do this cleanup now, rather than punting it.
17	17

	18 // Computes a uint64 hash of a given string based on its MD5 hash. Suitable for

	19 // metric names.

	20 uint64 HashMetricName(const std::string& name);

	21

18 } // namespace metrics	22 } // namespace metrics

19	23

20 #endif // COMPONENTS_VARIATIONS_METRICS_UTIL_H_	24 #endif // COMPONENTS_VARIATIONS_METRICS_UTIL_H_

OLD	NEW