Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 497503003: Update FDO options to match what is needed by the framework (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update FDO options to match what is needed by the framework Committed: https://skia.googlesource.com/skia/+/6bf35c21003b8d1c8286c90a53c0b3091f5aa85a

Patch Set 1 #

Patch Set 2 : making code uglier to satisfy python linter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M platform_tools/android/gyp_gen/makefile_writer.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M platform_tools/android/tests/expectations/Android.mk View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
djsollen
6 years, 4 months ago (2014-08-21 14:10:19 UTC) #1
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-08-21 14:21:50 UTC) #2
tomhudson
lgtm
6 years, 4 months ago (2014-08-21 14:21:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/497503003/1
6 years, 4 months ago (2014-08-21 14:22:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 14:22:17 UTC) #5
commit-bot: I haz the power
Presubmit check for 497503003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-08-21 14:22:18 UTC) #6
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-08-21 14:29:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/497503003/20001
6 years, 4 months ago (2014-08-21 14:30:09 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 14:38:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 6bf35c21003b8d1c8286c90a53c0b3091f5aa85a

Powered by Google App Engine
This is Rietveld 408576698