Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 497503003: Update FDO options to match what is needed by the framework (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: making code uglier to satisfy python linter Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/gyp_gen/makefile_writer.py
diff --git a/platform_tools/android/gyp_gen/makefile_writer.py b/platform_tools/android/gyp_gen/makefile_writer.py
index ddd584e9a2a657b8ee351a44a9c24f2794c528e1..55a71d00ca00b14ae4e9e078a1f197e36afea9f0 100644
--- a/platform_tools/android/gyp_gen/makefile_writer.py
+++ b/platform_tools/android/gyp_gen/makefile_writer.py
@@ -194,7 +194,16 @@ def write_android_mk(target_dir, common, deviations_from_common):
f.write(DEBUGGING_HELP)
write_clear_vars(f)
+
+ # need flags to enable feedback driven optimization (FDO) when requested
+ # by the build system.
f.write('LOCAL_FDO_SUPPORT := true\n')
+ f.write(
+ 'ifneq ($(strip $($(LOCAL_2ND_ARCH_VAR_PREFIX)TARGET_FDO_CFLAGS)),)\n')
+ f.write('\t# This should be the last -Oxxx specified in LOCAL_CFLAGS\n')
+ f.write('\tLOCAL_CFLAGS += -O2\n')
+ f.write('endif\n\n')
+
f.write('LOCAL_ARM_MODE := thumb\n')
# need a flag to tell the C side when we're on devices with large memory
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698