pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart - Issue 497393002: Make more use of generated code in analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 497393002: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_import.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

index eba3a0bf037ce759996ab3fdc49567ffb08126cb..e7c72aad58f44931979cc45a067089fda6bb95bb 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

@@ -6,8 +6,8 @@ library services.src.refactoring.rename_constructor;

import 'dart:async';

-import 'package:analysis_server/src/protocol2.dart' show Location, SourceEdit;

-import 'package:analysis_server/src/services/correction/change.dart';

+import 'package:analysis_server/src/protocol2.dart' show Location,

+ SourceChange, SourceEdit;

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analysis_server/src/services/search/hierarchy.dart';

@@ -50,8 +50,8 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {

}

@override

- Future<Change> createChange() {

- Change change = new Change(refactoringName);

+ Future<SourceChange> createChange() {

+ SourceChange change = new SourceChange(refactoringName);

String replacement = newName.isEmpty ? '' : '.${newName}';

// update references

return searchEngine.searchReferences(element).then((refMatches) {