Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 497223003: Revert of Replace StreamListenSocket with StreamSocket in HttpServer. (Closed)

Created:
6 years, 4 months ago by Evan Stade
Modified:
6 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yurys, abarth-chromium, Aaron Boodman, paulirish+reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, devtools-reviews_chromium.org, stgao, aandrey+blink_chromium.org, ben+mojo_chromium.org, darin (slow to review), gunsch, mnaganov (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Replace StreamListenSocket with StreamSocket in HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/) Reason for revert: looks like it caused net_unittests failures: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/44610/steps/net_unittests/logs/MultipleRequestsOnSameConnection Original issue's description: > Replace StreamListenSocket with StreamSocket in HttpServer. > > 1) HttpServer gets ServerSocket instead of StreamListenSocket. > 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers. > 3) HttpServer handles data buffering and asynchronous read/write. > 4) HttpConnection has limit in data buffering, up to 1Mbytes by default. > 5) For devtools, send buffer limit is 100Mbytes. > 6) Unittests for buffer handling in HttpConnection. > > BUG=371906 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291447 NOTREECHECKS=true NOTRY=true TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -1422 lines) Patch
M android_webview/native/aw_dev_tools_server.cc View 3 chunks +5 lines, -24 lines 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 3 chunks +5 lines, -48 lines 0 comments Download
M chrome/browser/devtools/device/android_web_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 2 chunks +2 lines, -25 lines 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/net/test_http_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/test_http_server.cc View 5 chunks +14 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chromecast/shell/browser/devtools/remote_debugging_server.cc View 3 chunks +7 lines, -46 lines 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/devtools/devtools_browser_target.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 15 chunks +19 lines, -63 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_unittest.cc View 6 chunks +41 lines, -58 lines 0 comments Download
M content/public/browser/devtools_http_handler.h View 3 chunks +2 lines, -29 lines 0 comments Download
M content/shell/browser/shell_devtools_delegate.cc View 4 chunks +7 lines, -45 lines 0 comments Download
M extensions/browser/api/socket/tcp_socket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/spy/websocket_server.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/spy/websocket_server.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/server/http_connection.h View 1 chunk +19 lines, -106 lines 0 comments Download
M net/server/http_connection.cc View 1 chunk +23 lines, -142 lines 0 comments Download
D net/server/http_connection_unittest.cc View 1 chunk +0 lines, -331 lines 0 comments Download
M net/server/http_server.h View 4 chunks +31 lines, -41 lines 0 comments Download
M net/server/http_server.cc View 7 chunks +82 lines, -197 lines 0 comments Download
M net/server/http_server_response_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/server/http_server_response_info.cc View 1 chunk +1 line, -7 lines 0 comments Download
M net/server/http_server_unittest.cc View 6 chunks +15 lines, -107 lines 0 comments Download
M net/server/web_socket.h View 3 chunks +4 lines, -9 lines 0 comments Download
M net/server/web_socket.cc View 11 chunks +73 lines, -90 lines 0 comments Download
M net/socket/server_socket.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Stade
Created Revert of Replace StreamListenSocket with StreamSocket in HttpServer.
6 years, 4 months ago (2014-08-22 21:03:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/497223003/1
6 years, 4 months ago (2014-08-22 21:04:59 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 21:04:59 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-22 21:05:00 UTC) #4
byungchul
On 2014/08/22 21:05:00, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 4 months ago (2014-08-22 21:08:22 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 4 months ago (2014-08-22 21:40:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/497223003/1
6 years, 4 months ago (2014-08-22 21:41:31 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 22:00:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 291521

Powered by Google App Engine
This is Rietveld 408576698