Expand empty directories in GN to "."

Expand empty directories in GN to "."

When a directory substitution in a toolchain definition expands to the empty
string (i.e. it's the same as the root build directory), expand the name to "."
instead of the empty string to avoid corrupting filenames.

For example, if you specified "{{target_out_dir}}/foo" without this it would
expand to "/foo" for the default toolchain.

This removes the previous special-case hack for this case. That code only
worked when the entire string expanded to the filename (when the directory was
at the beginning of the string). When generating command lines, the directories
will be in the middle of the string and the previous special case didn't catch
them.

R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291469

[jamesr, 2014-08-22 19:04:51]

lgtm

https://codereview.chromium.org/497193002/diff/20001/tools/gn/substitution_wr...
File tools/gn/substitution_writer.cc (right):

https://codereview.chromium.org/497193002/diff/20001/tools/gn/substitution_wr...
tools/gn/substitution_writer.cc:22: // directories will end in a trailing
slash). If the directory is empty
"If the directory is empty ...." what happens?

[brettw, 2014-08-22 19:14:36]

Committed patchset #2 manually as 291469 (presubmit successful).