Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: tools/gn/substitution_writer_unittest.cc

Issue 497193002: Expand empty directories in GN to "." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/substitution_writer.cc ('K') | « tools/gn/substitution_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_writer_unittest.cc
diff --git a/tools/gn/substitution_writer_unittest.cc b/tools/gn/substitution_writer_unittest.cc
index f17e31db996d03b82fdf968fc0f7247ad0288108..fc6cc74f9a9fc4974d5eac702cff9be458fb4abe 100644
--- a/tools/gn/substitution_writer_unittest.cc
+++ b/tools/gn/substitution_writer_unittest.cc
@@ -190,7 +190,7 @@ TEST(SubstitutionWriter, TargetSubstitutions) {
EXPECT_TRUE(SubstitutionWriter::GetTargetSubstitution(
&target, SUBSTITUTION_ROOT_OUT_DIR, &result));
- EXPECT_EQ("", result);
+ EXPECT_EQ(".", result);
EXPECT_TRUE(SubstitutionWriter::GetTargetSubstitution(
&target, SUBSTITUTION_TARGET_GEN_DIR, &result));
@@ -253,5 +253,5 @@ TEST(SubstitutionWriter, LinkerSubstitutions) {
OutputFile output = SubstitutionWriter::ApplyPatternToLinkerAsOutputFile(
&target, tool, pattern);
- EXPECT_EQ("libbaz.so", output.value());
+ EXPECT_EQ("./libbaz.so", output.value());
}
« tools/gn/substitution_writer.cc ('K') | « tools/gn/substitution_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698