Make some ScriptValue references const in modules/indexeddb

Make some ScriptValue references const in modules/indexeddb

These functions are called from the bindings layer, so the non-const
references bind to its local variables, and thus limit what we can do
in the generated code; the parameter value must be an lvalue.

There was no obvious reason why these references should be non-const.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180883

[Jens Widell, 2014-08-22 12:06:28]

PTAL

https://codereview.chromium.org/497033002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBObjectStore.cpp (left):

https://codereview.chromium.org/497033002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBObjectStore.cpp:189: value.clear();
This call had to go when the reference is const. I'm not sure why it was here,
though. Safe-guard against accidental use of |value| instead of |clone|?

[jsbell, 2014-08-22 16:09:21]

lgtm

https://codereview.chromium.org/497033002/diff/1/Source/modules/indexeddb/IDB...
File Source/modules/indexeddb/IDBObjectStore.cpp (left):

https://codereview.chromium.org/497033002/diff/1/Source/modules/indexeddb/IDB...
Source/modules/indexeddb/IDBObjectStore.cpp:189: value.clear();
On 2014/08/22 12:06:28, Jens Widell wrote:
> Safe-guard against accidental use of |value| instead of |clone|?

That's exactly it.

[Jens Widell, 2014-08-22 16:12:28]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-08-22 16:13:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497033002/1

[commit-bot: I haz the power, 2014-08-22 17:19:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23992)

[commit-bot: I haz the power, 2014-08-22 17:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 17:21:38]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[Jens Widell, 2014-08-22 19:13:55]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-08-22 19:14:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497033002/1

[commit-bot: I haz the power, 2014-08-22 19:17:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[commit-bot: I haz the power, 2014-08-22 19:20:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 19:20:16]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[Jens Widell, 2014-08-26 05:10:11]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-08-26 05:10:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/497033002/1

[commit-bot: I haz the power, 2014-08-26 05:15:18]

Committed patchset #1 (1) as 180883