Source/modules/indexeddb/IDBObjectStore.h - Issue 497033002: Make some ScriptValue references const in modules/indexeddb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBObjectStore.h

Issue 497033002: Make some ScriptValue references const in modules/indexeddb (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/indexeddb/IDBObjectStore.h

diff --git a/Source/modules/indexeddb/IDBObjectStore.h b/Source/modules/indexeddb/IDBObjectStore.h

index ecd8d24a82d716d23216acb9e3ec6568ace566b4..fd8e05d05cdc74297e7423a8bee9672fd9a364da 100644

--- a/Source/modules/indexeddb/IDBObjectStore.h

+++ b/Source/modules/indexeddb/IDBObjectStore.h

@@ -69,8 +69,8 @@ public:

IDBRequest* openCursor(ScriptState*, const ScriptValue& range, const String& direction, ExceptionState&);

IDBRequest* openKeyCursor(ScriptState*, const ScriptValue& range, const String& direction, ExceptionState&);

IDBRequest* get(ScriptState*, const ScriptValue& key, ExceptionState&);

- IDBRequest* add(ScriptState*, ScriptValue&, const ScriptValue& key, ExceptionState&);

- IDBRequest* put(ScriptState*, ScriptValue&, const ScriptValue& key, ExceptionState&);

+ IDBRequest* add(ScriptState*, const ScriptValue&, const ScriptValue& key, ExceptionState&);

+ IDBRequest* put(ScriptState*, const ScriptValue&, const ScriptValue& key, ExceptionState&);

IDBRequest* deleteFunction(ScriptState*, const ScriptValue& key, ExceptionState&);

IDBRequest* clear(ScriptState*, ExceptionState&);

@@ -88,7 +88,7 @@ public:

IDBRequest* count(ScriptState*, const ScriptValue& range, ExceptionState&);

// Used by IDBCursor::update():

- IDBRequest* put(ScriptState*, WebIDBPutMode, IDBAny* source, ScriptValue&, IDBKey*, ExceptionState&);

+ IDBRequest* put(ScriptState*, WebIDBPutMode, IDBAny* source, const ScriptValue&, IDBKey*, ExceptionState&);

// Used internally and by InspectorIndexedDBAgent:

IDBRequest* openCursor(ScriptState*, IDBKeyRange*, WebIDBCursorDirection, WebIDBTaskType = WebIDBTaskTypeNormal);

@@ -109,7 +109,7 @@ private:

IDBIndex* createIndex(ScriptState*, const String& name, const IDBKeyPath&, const Dictionary&, ExceptionState&);

IDBIndex* createIndex(ScriptState*, const String& name, const IDBKeyPath&, bool unique, bool multiEntry, ExceptionState&);

- IDBRequest* put(ScriptState*, WebIDBPutMode, IDBAny* source, ScriptValue&, const ScriptValue& key, ExceptionState&);

+ IDBRequest* put(ScriptState*, WebIDBPutMode, IDBAny* source, const ScriptValue&, const ScriptValue& key, ExceptionState&);

int64_t findIndexId(const String& name) const;

bool containsIndex(const String& name) const

« no previous file with comments | « Source/modules/indexeddb/IDBCursor.cpp ('k') | Source/modules/indexeddb/IDBObjectStore.cpp » ('j') | Source/modules/indexeddb/IDBObjectStore.cpp » ('J')