chrome/chrome_browser_extensions.gypi - Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_extensions.gypi

Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests mostly work Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser_extensions.gypi

diff --git a/chrome/chrome_browser_extensions.gypi b/chrome/chrome_browser_extensions.gypi

index 50cfe098171ffef6d45959177ad834b802de8a46..8d14c69613f889e179e520a693217bec89c3b3fd 100644

--- a/chrome/chrome_browser_extensions.gypi

+++ b/chrome/chrome_browser_extensions.gypi

@@ -189,13 +189,12 @@

'browser/extensions/api/declarative/declarative_api.cc',

'browser/extensions/api/declarative/declarative_api.h',

'browser/extensions/api/declarative/declarative_rule.h',

- 'browser/extensions/api/declarative/initializing_rules_registry.cc',

- 'browser/extensions/api/declarative/initializing_rules_registry.h',

+ 'browser/extensions/api/declarative/rules_cache_delegate.cc',

+ 'browser/extensions/api/declarative/rules_cache_delegate.h',

+ 'browser/extensions/api/declarative/rules_registry.cc',

'browser/extensions/api/declarative/rules_registry.h',

'browser/extensions/api/declarative/rules_registry_service.cc',

'browser/extensions/api/declarative/rules_registry_service.h',

- 'browser/extensions/api/declarative/rules_registry_with_cache.cc',

- 'browser/extensions/api/declarative/rules_registry_with_cache.h',

'browser/extensions/api/declarative/test_rules_registry.cc',

'browser/extensions/api/declarative/test_rules_registry.h',

'browser/extensions/api/declarative_content/content_action.cc',

@@ -950,7 +949,6 @@

['include', '^browser/extensions/api/content_settings/content_settings_api_constants.cc'],

['include', '^browser/extensions/api/content_settings/content_settings_helpers.cc'],

['include', '^browser/extensions/api/content_settings/content_settings_store.cc'],

- ['include', '^browser/extensions/api/declarative/initializing_rules_registry.cc'],

['include', '^browser/extensions/api/declarative/rules_registry_service.cc'],

['include', '^browser/extensions/api/declarative/rules_registry_with_cache.cc'],

['include', '^browser/extensions/api/declarative/substring_set_matcher.cc'],