chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 49693003: Refactor RulesRegistryWithCache to RulesRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests mostly work Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

index 7dc19f7ade9a989e75b571794dd926fe437a03b9..aea39111ffd0f0d4c3915309e71f177a8766518e 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -36,12 +36,12 @@ namespace extensions {

WebRequestRulesRegistry::WebRequestRulesRegistry(

Profile* profile,

- scoped_ptr<RulesRegistryWithCache::RuleStorageOnUI>* ui_part)

- : RulesRegistryWithCache((ui_part ? profile : NULL),

- declarative_webrequest_constants::kOnRequest,

- content::BrowserThread::IO,

- true /*log_storage_init_delay*/,

- ui_part),

+ scoped_ptr<RulesCacheDelegate>* cache_delegate)

+ : RulesRegistry((cache_delegate ? profile : NULL),

+ declarative_webrequest_constants::kOnRequest,

+ content::BrowserThread::IO,

+ true /*log_storage_init_delay*/,

+ cache_delegate),

profile_id_(profile) {

if (profile)

extension_info_map_ = ExtensionSystem::Get(profile)->info_map();