Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

Issue 496873006: Move core web_view code to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h
diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h
index ac0aefc75d1b3ee370865c0427083601505fd815..98069a9c89368d86436bf429e8c96c37c74e6809 100644
--- a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h
+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h
@@ -8,6 +8,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/media_stream_request.h"
+#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
namespace extensions {
@@ -15,7 +16,8 @@ namespace extensions {
// not a part of extensions.
class WebViewPermissionHelperDelegate : public content::WebContentsObserver {
public:
- explicit WebViewPermissionHelperDelegate(content::WebContents* contents);
+ explicit WebViewPermissionHelperDelegate(
+ extensions::WebViewPermissionHelper* web_view_permission_helper);
Fady Samuel 2014/08/22 16:40:17 Given we are already in the extensions namespace,
Xi Han 2014/08/22 18:04:53 Good catch, thanks. I just forget to remove these
virtual ~WebViewPermissionHelperDelegate();
virtual void RequestMediaAccessPermission(
@@ -83,7 +85,13 @@ class WebViewPermissionHelperDelegate : public content::WebContentsObserver {
bool blocked_by_policy,
IPC::Message* reply_msg) {}
+ extensions:: WebViewPermissionHelper* web_view_permission_helper() {
Fady Samuel 2014/08/22 16:40:17 web_view_permission_helper() const Also, I don't
Xi Han 2014/08/22 18:04:52 Done.
+ return web_view_permission_helper_;
+ }
+
private:
+ extensions::WebViewPermissionHelper* web_view_permission_helper_;
Fady Samuel 2014/08/22 16:40:17 This indicates that the WebViewPermissionHelper ca
Xi Han 2014/08/22 18:04:52 Done.
+
DISALLOW_COPY_AND_ASSIGN(WebViewPermissionHelperDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698