extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc - Issue 496873006: Move core web_view code to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

Issue 496873006: Move core web_view code to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h ('K') | « extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h ('k') | extensions/browser/guest_view/web_view/web_view_permission_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

index d53d64d1f861e954589d3fe7629df860ce19e771..0e0b534cfda2921fb8c80dd9330c3a2a8b265a2b 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.cc

@@ -4,11 +4,15 @@

#include "extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h"

+#include "extensions/browser/guest_view/web_view/web_view_guest.h"

namespace extensions {

WebViewPermissionHelperDelegate::WebViewPermissionHelperDelegate(

- content::WebContents* contents)

- : content::WebContentsObserver(contents) {

+ extensions::WebViewPermissionHelper* web_view_permission_helper)

Fady Samuel 2014/08/22 16:40:17 Drop extensions::

Xi Han 2014/08/22 18:04:52 Done.

+ : content::WebContentsObserver(

+ web_view_permission_helper->web_view_guest()->guest_web_contents()),

+ web_view_permission_helper_(web_view_permission_helper) {

}

WebViewPermissionHelperDelegate::~WebViewPermissionHelperDelegate() {