Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user

Multiprofile security: Show a warning messagebox when desktop
casting/sharing is turned on upon user switch

Purpose of this change:

Asks the user with a system modal dialog box if he wants to
turn off screen sharing/screen casting and then switch users
or abort switching users.

BUG=353170
TEST=TrySwitchingUserTest.*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291276

[Mr4D (OOO till 08-26), 2014-08-20 22:15:52]

Please have a look!

Added Jamescook for owner review of chrome/browser/ui/ash/*

Many thanks in advance!

[jennyz, 2014-08-20 23:28:05]

lgtm with nits.

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grdp
File ash/ash_chromeos_strings.grdp (right):

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grd...
ash/ash_chromeos_strings.grdp:142: Screen sharing will stop when you switch to
another user. Do you want to continue?
My English is bad. stop -> be stopped?

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
File chrome/browser/ui/ash/session_state_delegate_chromeos.h (right):

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.h:80: // wants to stop
desktop casting before switching.
nit: Switch -> Switches.

[James Cook, 2014-08-20 23:33:53]

c/b/ui/ash LGTM with nits

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grdp
File ash/ash_chromeos_strings.grdp (right):

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grd...
ash/ash_chromeos_strings.grdp:142: Screen sharing will stop when you switch to
another user. Do you want to continue?
On 2014/08/20 23:28:05, jennyz wrote:
> My English is bad. stop -> be stopped?

Native English speaker: Either way sounds fine to me.

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:9: #include
"ash/shell.h"
Do you need this include?

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:10: #include
"ash/system/chromeos/multi_user/try_switching_user.h"
This filename is a little weird. How about something like "user_switching_util"
or "user_switch_util" or similar?

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:282:
ash::TrySwitchingActiveUser(switch_user);
nit: You could just put the base::Bind() call here.

[Mr4D (OOO till 08-26), 2014-08-21 00:05:03]

Addressed! Many thanks for your quick review!

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grdp
File ash/ash_chromeos_strings.grdp (right):

https://codereview.chromium.org/496563002/diff/1/ash/ash_chromeos_strings.grd...
ash/ash_chromeos_strings.grdp:142: Screen sharing will stop when you switch to
another user. Do you want to continue?
On 2014/08/20 23:33:53, James Cook wrote:
> On 2014/08/20 23:28:05, jennyz wrote:
> > My English is bad. stop -> be stopped?
> 
> Native English speaker: Either way sounds fine to me.

Acknowledged.

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (right):

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:9: #include
"ash/shell.h"
On 2014/08/20 23:33:53, James Cook wrote:
> Do you need this include?

Done.

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:10: #include
"ash/system/chromeos/multi_user/try_switching_user.h"
I have found some similarly named cc/h files. But they sounded odd to me as
well. Changed as requested. Done.

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.cc:282:
ash::TrySwitchingActiveUser(switch_user);
On 2014/08/20 23:33:53, James Cook wrote:
> nit: You could just put the base::Bind() call here.

Done.

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
File chrome/browser/ui/ash/session_state_delegate_chromeos.h (right):

https://codereview.chromium.org/496563002/diff/1/chrome/browser/ui/ash/sessio...
chrome/browser/ui/ash/session_state_delegate_chromeos.h:80: // wants to stop
desktop casting before switching.
On 2014/08/20 23:28:05, jennyz wrote:
> nit: Switch -> Switches.

Done.

[Mr4D (OOO till 08-26), 2014-08-21 00:05:06]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-21 00:06:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/496563002/20001

[commit-bot: I haz the power, 2014-08-21 01:27:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 01:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 01:30:35]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Mr4D (OOO till 08-26), 2014-08-21 02:14:51]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-21 02:15:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/496563002/20001

[commit-bot: I haz the power, 2014-08-21 02:31:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-21 02:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 02:42:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mr4D (OOO till 08-26), 2014-08-21 13:50:23]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-21 13:51:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/496563002/20001

[commit-bot: I haz the power, 2014-08-21 14:29:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mr4D (OOO till 08-26), 2014-08-21 15:05:23]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-21 15:07:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/496563002/40001

[commit-bot: I haz the power, 2014-08-21 19:19:23]

Committed patchset #3 (40001) as 291152

[dewittj, 2014-08-21 20:12:12]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/473953004/ by dewittj@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Tests on waterfall:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[Mr4D (OOO till 08-26), 2014-08-21 21:50:00]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:51:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skuhne@chromium.org/496563002/80001

[commit-bot: I haz the power, 2014-08-22 00:05:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-22 00:47:25]

Committed patchset #4 (80001) as 291276