Issue 496493003: Video Player: Enable cast feature by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496493003: Video Player: Enable cast feature by default (Closed)

Created:
6 years, 4 months ago by yoshiki

Modified:
6 years, 3 months ago

Reviewers:

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Video Player: Enable cast feature by default The branch point has passes so, this patch enables the feature again. This patch is the revert of r289621. BUG=305511 TEST=Confirms the cast icon appears when cast is available. TBR=hirono@chromium.org Committed: https://crrev.com/6239d1fec186fe3da8bdf6e675ef9a2ea149d7f7 Cr-Commit-Position: refs/heads/master@{#291637}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -19 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	ui/file_manager/video_player/js/cast/caster.js	View		1 chunk	+1 line, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/496493003/1

6 years, 4 months ago (2014-08-25 02:25:24 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (1) as a74e3c82750db289342557a0c56193b411346246

6 years, 4 months ago (2014-08-25 03:19:13 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:01 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6239d1fec186fe3da8bdf6e675ef9a2ea149d7f7
Cr-Commit-Position: refs/heads/master@{#291637}

Expand Messages | Collapse Messages