Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'

Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'

With the deletion of .DEPS.git, 'webkit_rev' became 'webkit_revision':
https://codereview.chromium.org/497313003

Without this change, gclient sync will not get the latest Blink commit.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291716

[philipj_slow, 2014-08-27 12:06:22]

philipj@opera.com changed reviewers:
+ iannucci@chromium.org

[philipj_slow, 2014-08-27 12:06:23]

PTAL. This is my first depot_tools change, so I don't know what I'm doing.

[ghost stip (do not use), 2014-08-27 21:14:47]

stip@chromium.org changed reviewers:
+ stip@chromium.org

[ghost stip (do not use), 2014-08-27 21:14:47]

https://codereview.chromium.org/496443005/diff/1/git-crup
File git-crup (right):

https://codereview.chromium.org/496443005/diff/1/git-crup#newcode38
git-crup:38: # 'custom_vars': {'webkit_revision': ''},
I was under the impression that git-crup was deprecated.

[philipj_slow, 2014-08-27 21:19:23]

https://codereview.chromium.org/496443005/diff/1/git-crup
File git-crup (right):

https://codereview.chromium.org/496443005/diff/1/git-crup#newcode38
git-crup:38: # 'custom_vars': {'webkit_revision': ''},
On 2014/08/27 21:14:47, stip wrote:
> I was under the impression that git-crup was deprecated.

I found it when grepping so I updated it. Should I remove it or leave it broken
instead?

[Dirk Pranke, 2014-08-27 21:20:08]

dpranke@chromium.org changed reviewers:
+ szager@chromium.org

[Dirk Pranke, 2014-08-27 21:21:17]

On 2014/08/27 21:20:08, Dirk Pranke wrote:
> mailto:dpranke@chromium.org changed reviewers:
> + mailto:szager@chromium.org

I think szager is probably the best person to review this. The changes to
blink.py and chromium.py look correct to me, but I don't recall why we had two
different variable names in the first place, and I'd like szager's input if
possible.

szager is also the best person to say if git-crup (and git-crsync) should be
removed or not.

[Dirk Pranke, 2014-08-27 21:23:03]

On 2014/08/27 21:21:17, Dirk Pranke wrote:
> On 2014/08/27 21:20:08, Dirk Pranke wrote:
> > mailto:dpranke@chromium.org changed reviewers:
> > + mailto:szager@chromium.org
> 
> I think szager is probably the best person to review this. The changes to
> blink.py and chromium.py look correct to me, but I don't recall why we had two
> different variable names in the first place, and I'd like szager's input if
> possible.
> 
> szager is also the best person to say if git-crup (and git-crsync) should be
> removed or not.

We should probably also send out a PSA to blink-dev noting that anyone who has a
'webkit_rev' custom var in their .gclient should change it to 'webkit_revision',
but I want to hold off on that until after Stefan can weigh in, if possible.

Given that this has apparently been broken for 4 days and only you (and now me
now that I'm back from vacation) have noticed it, it doesn't seem like it's
crippling most devs, who apparently either manually do 'git pull' on the repo or
use safely-update-webkit.py.

[philipj_slow, 2014-08-27 21:28:27]

On 2014/08/27 21:23:03, Dirk Pranke wrote:
> On 2014/08/27 21:21:17, Dirk Pranke wrote:
> > On 2014/08/27 21:20:08, Dirk Pranke wrote:
> > > mailto:dpranke@chromium.org changed reviewers:
> > > + mailto:szager@chromium.org
> > 
> > I think szager is probably the best person to review this. The changes to
> > blink.py and chromium.py look correct to me, but I don't recall why we had
two
> > different variable names in the first place, and I'd like szager's input if
> > possible.
> > 
> > szager is also the best person to say if git-crup (and git-crsync) should be
> > removed or not.
> 
> We should probably also send out a PSA to blink-dev noting that anyone who has
a
> 'webkit_rev' custom var in their .gclient should change it to
'webkit_revision',
> but I want to hold off on that until after Stefan can weigh in, if possible.
> 
> Given that this has apparently been broken for 4 days and only you (and now me
> now that I'm back from vacation) have noticed it, it doesn't seem like it's
> crippling most devs, who apparently either manually do 'git pull' on the repo
or
> use safely-update-webkit.py.

What's safely-update-webkit.py?

[szager1, 2014-08-27 21:29:03]

https://codereview.chromium.org/496443005/diff/1/git-crup
File git-crup (right):

https://codereview.chromium.org/496443005/diff/1/git-crup#newcode38
git-crup:38: # 'custom_vars': {'webkit_revision': ''},
On 2014/08/27 21:19:23, philipj wrote:
> On 2014/08/27 21:14:47, stip wrote:
> > I was under the impression that git-crup was deprecated.
> 
> I found it when grepping so I updated it. Should I remove it or leave it
broken
> instead?

This change is fine, no point in deliberately breaking it.  We may revive it
some day.

[philipj_slow, 2014-08-28 11:37:53]

Reviewers, is this CL good for landing now? If no one else want the honor, I can
also send out the PSA on blink-dev.

[szager1, 2014-08-28 21:27:59]

lgtm

Are we confident this hits all the reference to webkit_rev?

[philipj_slow, 2014-08-28 21:51:49]

On 2014/08/28 21:27:59, szager1 wrote:
> lgtm
> 
> Are we confident this hits all the reference to webkit_rev?

These are the only occurrences in depot_tools. In Chromium there's one instance
used in a test that shouldn't matter, and no matches in Blink.

Is there someplace else they could be left behind?

[philipj_slow, 2014-08-28 21:52:05]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-08-28 21:52:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/496443005/1

[commit-bot: I haz the power, 2014-08-28 21:54:25]

Committed patchset #1 (id:1) as 291716