git-crup - Issue 496443005: Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git-crup

Issue 496443005: Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev' (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git-crup

diff --git a/git-crup b/git-crup

index 3b8cc697bd9a7bebea8497728e6ee8379e137265..b2d1a92bf227afc5aa8afa0016d7a57ea7c89158 100755

--- a/git-crup

+++ b/git-crup

@@ -35,7 +35,7 @@ solutions = [{

'managed': False,

'deps_file': '.DEPS.git',

# Uncomment the following if you're doing blink development

- # 'custom_vars': {'webkit_rev': ''},

+ # 'custom_vars': {'webkit_revision': ''},

ghost stip (do not use) 2014/08/27 21:14:47 I was under the impression that git-crup was depre

philipj_slow 2014/08/27 21:19:23 I found it when grepping so I updated it. Should I

szager1 2014/08/27 21:29:02 This change is fine, no point in deliberately brea

}]

# ======== .gclient ends =========

« no previous file with comments | « no previous file | recipes/blink.py » ('j') | no next file with comments »