Issue 496153002: 1.5x -> 2x text size for y pad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496153002: 1.5x -> 2x text size for y pad. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

1.5x -> 2x text size for y pad. This will expand the cheat to just big enough to pass an assertion coming from our GDI bot. Currently failing: -6.000000 -1.500000 6.000000 1.500000 vs. -1.000000 -2.000000 3.000000 1.000000 Will become (-8 -2 8 2) vs. (-1 -2 3 1). BUG=skia: Committed: https://skia.googlesource.com/skia/+/c8460493adbaba5acef69b3127c452df99117b24

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/core/SkRecordDraw.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/496153002/1

6 years, 4 months ago (2014-08-21 23:32:01 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 23:39:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as c8460493adbaba5acef69b3127c452df99117b24

Expand Messages | Collapse Messages