src/core/SkRecordDraw.cpp - Issue 496153002: 1.5x -> 2x text size for y pad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRecordDraw.cpp

Issue 496153002: 1.5x -> 2x text size for y pad. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRecordDraw.cpp

diff --git a/src/core/SkRecordDraw.cpp b/src/core/SkRecordDraw.cpp

index db4e87fbcee70cbeecb56d6d86e207aeb29b428c..a14b0316955dd0b1c93448c1bcd2410c5f74bae8 100644

--- a/src/core/SkRecordDraw.cpp

+++ b/src/core/SkRecordDraw.cpp

@@ -316,7 +316,7 @@ private:

#ifdef SK_DEBUG

SkRect correct = *rect;

#endif

- const SkScalar yPad = 1.5f * paint.getTextSize(), // In practice, this seems to be enough.

+ const SkScalar yPad = 2.0f * paint.getTextSize(), // In practice, this seems to be enough.

xPad = 4.0f * yPad; // Hack for very wide Github logo font.

rect->outset(xPad, yPad);

#ifdef SK_DEBUG

« no previous file with comments | « no previous file | no next file » | no next file with comments »