content/renderer/media/android/webmediaplayer_android.h - Issue 496103002: Fix the ownership of media_log_ in WebMediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 496103002: Fix the ownership of media_log_ in WebMediaPlayerAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: passing refptr to MediaSourceDelegate Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index 3e8530f083b67533f4d265a224081bc65adac1e4..1fd84b95ba72570897f0b9857d9ca50a105fdace 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -451,7 +451,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,

// Whether the browser is currently connected to a remote media player.

bool is_remote_;

- media::MediaLog* media_log_;

+ scoped_refptr<media::MediaLog> media_log_;

scoped_ptr<MediaInfoLoader> info_loader_;