content/renderer/media/android/media_source_delegate.h - Issue 496103002: Fix the ownership of media_log_ in WebMediaPlayerAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/media_source_delegate.h

Issue 496103002: Fix the ownership of media_log_ in WebMediaPlayerAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: passing refptr to MediaSourceDelegate Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/media_source_delegate.h

diff --git a/content/renderer/media/android/media_source_delegate.h b/content/renderer/media/android/media_source_delegate.h

index 28b18325938d1cdc9397bb64f0cef3a6c51c68ae..fe2f1b4006b519512b134fa7ab5e2f51010d1d38 100644

--- a/content/renderer/media/android/media_source_delegate.h

+++ b/content/renderer/media/android/media_source_delegate.h

@@ -56,7 +56,7 @@ class MediaSourceDelegate : public media::DemuxerHost {

MediaSourceDelegate(RendererDemuxerAndroid* demuxer_client,

int demuxer_client_id,

const scoped_refptr<base::MessageLoopProxy>& media_loop,

- media::MediaLog* media_log);

+ scoped_refptr<media::MediaLog> media_log);

xhwang 2014/08/22 02:34:06 nit: in media code, we pass scoped_refptr by const

qinmin 2014/08/22 16:32:08 Done.

// Initialize the MediaSourceDelegate. |media_source| will be owned by

// this object after this call.

« no previous file with comments | « no previous file | content/renderer/media/android/media_source_delegate.cc » ('j') | no next file with comments »