Issue 495843003: Handle a non-existing promise when receiving a signin error in the SupervisedUserListData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495843003: Handle a non-existing promise when receiving a signin error in the SupervisedUserListData. (Closed)

Created:
6 years, 4 months ago by Bernhard Bauer

Modified:
6 years, 3 months ago

Reviewers:
Marc Treib

CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Handle a non-existing promise when receiving a signin error in the SupervisedUserListData. BUG=405709 Committed: https://crrev.com/e3fe689a904f00128be9d1482568737626a5338c Cr-Commit-Position: refs/heads/master@{#291883}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
	M	chrome/browser/resources/options/supervised_user_list_data.js	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/webui/options/manage_profile_browsertest.js	View	1	1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 7 (0 generated)

Bernhard Bauer

bauerb@chromium.org changed reviewers: + treib@chromium.org

6 years, 3 months ago (2014-08-26 08:48:22 UTC) #1

Marc Treib

On 2014/08/26 08:48:23, Bernhard Bauer wrote: > Please review. lgtm

6 years, 3 months ago (2014-08-26 08:53:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/495843003/20001

6 years, 3 months ago (2014-08-26 10:16:40 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (20001) as 1881430134eaae9d23a6ddffcdd0371aaadffacd

6 years, 3 months ago (2014-08-26 11:10:07 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:42:04 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/e3fe689a904f00128be9d1482568737626a5338c
Cr-Commit-Position: refs/heads/master@{#291883}