Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: chrome/browser/resources/options/supervised_user_list_data.js

Issue 495843003: Handle a non-existing promise when receiving a signin error in the SupervisedUserListData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reenable Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/manage_profile_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/supervised_user_list_data.js
diff --git a/chrome/browser/resources/options/supervised_user_list_data.js b/chrome/browser/resources/options/supervised_user_list_data.js
index 407634778bf64f6236be10f19fc01684f79079b9..f73feca63f0421b663ee1f78cf5363acea3aece2 100644
--- a/chrome/browser/resources/options/supervised_user_list_data.js
+++ b/chrome/browser/resources/options/supervised_user_list_data.js
@@ -31,8 +31,8 @@ cr.define('options', function() {
* }
* @private
*/
- SupervisedUserListData.prototype.receiveExistingSupervisedUsers_ = function(
- supervisedUsers) {
+ SupervisedUserListData.prototype.receiveExistingSupervisedUsers_ =
+ function(supervisedUsers) {
if (!this.promise_) {
this.onDataChanged_(supervisedUsers);
return;
@@ -46,7 +46,9 @@ cr.define('options', function() {
* @private
*/
SupervisedUserListData.prototype.onSigninError_ = function() {
- assert(this.promise_);
+ if (!this.promise_) {
+ return;
+ }
this.reject_();
this.resetPromise_();
};
« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/manage_profile_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698