Check the IME component extension's availability on linux_chromeos, so that system fallback VK can …

Check the IME component extension's availability on linux_chromeos, so that system fallback VK can be showed.

BUG=405042
TEST=Verified on linux_chromeos.

Committed: https://crrev.com/e36480b80bd6cb307a2dcf5317df16deb3073e94
Cr-Commit-Position: refs/heads/master@{#291642}

[Shu Chen, 2014-08-21 07:02:07]

Nona, can you please review this cl? Thanks

[Seigo Nonaka, 2014-08-25 02:01:08]

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:290:
content::BrowserThread::PostTaskAndReply(
Probably, you may want to use PostTaskAndReplyWIthResult function.

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:301:
return false;
is it okay to return false here? Probably at least need to add comment to
header.

[Shu Chen, 2014-08-25 02:31:08]

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:290:
content::BrowserThread::PostTaskAndReply(
On 2014/08/25 02:01:08, Seigo Nonaka wrote:
> Probably, you may want to use PostTaskAndReplyWIthResult function.

Done.

https://codereview.chromium.org/495593004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:301:
return false;
On 2014/08/25 02:01:08, Seigo Nonaka wrote:
> is it okay to return false here? Probably at least need to add comment to
> header.

Done. I've made the return type as void.

[Seigo Nonaka, 2014-08-25 04:43:27]

lgtm with a nit pick

https://codereview.chromium.org/495593004/diff/60001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/495593004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:294:
if (!base::SysInfo::IsRunningOnChromeOS()) {
nit:
I perfer
if (condition) {
  // doing A
} else {
  // doing B
}

rather than
if (!condition) {
  // doing B
} else {
  // doing A
}

probably in this case

if (base::SysInfo::IsRunnningOnChromeOS()) {
  // In the case of real Chrome OS device, the no need to check the path
preinstalled files existence.
  DoLoadExtension(profile, extension_id, manifest, file_path);
  return;
}

// If current environment is linux_chromeos, check...
base::FilePath* ...

if clearer for me.

[Shu Chen, 2014-08-25 04:58:06]

https://codereview.chromium.org/495593004/diff/60001/chrome/browser/chromeos/...
File
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
(right):

https://codereview.chromium.org/495593004/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc:294:
if (!base::SysInfo::IsRunningOnChromeOS()) {
On 2014/08/25 04:43:27, Seigo Nonaka wrote:
> nit:
> I perfer
> if (condition) {
>   // doing A
> } else {
>   // doing B
> }
> 
> rather than
> if (!condition) {
>   // doing B
> } else {
>   // doing A
> }
> 
> probably in this case
> 
> if (base::SysInfo::IsRunnningOnChromeOS()) {
>   // In the case of real Chrome OS device, the no need to check the path
> preinstalled files existence.
>   DoLoadExtension(profile, extension_id, manifest, file_path);
>   return;
> }
> 
> // If current environment is linux_chromeos, check...
> base::FilePath* ...
> 
> if clearer for me.

Done.

[Shu Chen, 2014-08-25 04:59:40]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2014-08-25 05:00:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shuchen@chromium.org/495593004/80001

[commit-bot: I haz the power, 2014-08-25 05:55:27]

Committed patchset #5 (80001) as 67b1b3593eec812e957372f760f4645e158eecb5

[commit-bot: I haz the power, 2014-09-10 02:33:07]

Patchset 5 (id:??) landed as
https://crrev.com/e36480b80bd6cb307a2dcf5317df16deb3073e94
Cr-Commit-Position: refs/heads/master@{#291642}