chromeos/ime/component_extension_ime_manager.h - Issue 495593004: Check the IME component extension's availability on linux_chromeos, so that system fallback VK can …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/ime/component_extension_ime_manager.h

Issue 495593004: Check the IME component extension's availability on linux_chromeos, so that system fallback VK can … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chromeos/ime/component_extension_ime_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/ime/component_extension_ime_manager.h

diff --git a/chromeos/ime/component_extension_ime_manager.h b/chromeos/ime/component_extension_ime_manager.h

index a505332b330929b95fba2863ec1e7931b54006b4..98e0bbc26a62779d5a0f0ff19c963bec95fa7134 100644

--- a/chromeos/ime/component_extension_ime_manager.h

+++ b/chromeos/ime/component_extension_ime_manager.h

@@ -54,7 +54,7 @@ class CHROMEOS_EXPORT ComponentExtensionIMEManagerDelegate {

// Loads component extension IME associated with |extension_id|.

// Returns false if it fails, otherwise returns true.

- virtual bool Load(Profile* profile,

+ virtual void Load(Profile* profile,

const std::string& extension_id,

const std::string& manifest,

const base::FilePath& path) = 0;