Issue 495323003: Remove testRunner.globalFlag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495323003: Remove testRunner.globalFlag. (Closed)

Created:
6 years, 4 months ago by dcheng

Modified:
6 years, 3 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/0d23532176de4e93fadcb290171ad125ed0bd6ec Cr-Commit-Position: refs/heads/master@{#291589}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -20 lines)			Patch
	M	content/shell/renderer/test_runner/test_runner.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	content/shell/renderer/test_runner/test_runner.cc	View		4 chunks	+0 lines, -17 lines	0 comments	Download

Total messages: 7 (0 generated)

dcheng

This will only be landed once https://codereview.chromium.org/494343003 and https://codereview.chromium.org/475933003 land.

6 years, 4 months ago (2014-08-22 16:35:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/495323003/1

6 years, 4 months ago (2014-08-22 19:37:23 UTC) #4

dcheng

Committed patchset #1 to pending queue manually as 5da6cab (presubmit successful).

6 years, 4 months ago (2014-08-23 21:40:12 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:31:19 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0d23532176de4e93fadcb290171ad125ed0bd6ec
Cr-Commit-Position: refs/heads/master@{#291589}