Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: sdk/lib/_internal/pub/test/implicit_dependency_test.dart

Issue 494943002: Don't load assets unnecessarily when precompiling executables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/implicit_dependency_test.dart
diff --git a/sdk/lib/_internal/pub/test/implicit_dependency_test.dart b/sdk/lib/_internal/pub/test/implicit_dependency_test.dart
index 3f46637c499d1b68624038062d8e6f2a2b2d7ad8..34e133f8d1ecc4cd88642f80e84e9dd66a253281 100644
--- a/sdk/lib/_internal/pub/test/implicit_dependency_test.dart
+++ b/sdk/lib/_internal/pub/test/implicit_dependency_test.dart
@@ -12,14 +12,14 @@ main() {
forBothPubGetAndUpgrade((command) {
integration("implicitly constrains it to versions pub supports", () {
- servePackages([
- packageMap("barback", current("barback")),
- packageMap("stack_trace", previous("stack_trace")),
- packageMap("stack_trace", current("stack_trace")),
- packageMap("stack_trace", nextPatch("stack_trace")),
- packageMap("stack_trace", max("stack_trace")),
- packageMap("source_span", current("source_span"))
- ]);
+ servePackages((builder) {
+ builder.serve("barback", current("barback"));
+ builder.serve("stack_trace", previous("stack_trace"));
+ builder.serve("stack_trace", current("stack_trace"));
+ builder.serve("stack_trace", nextPatch("stack_trace"));
+ builder.serve("stack_trace", max("stack_trace"));
+ builder.serve("source_span", current("source_span"));
+ });
d.appDir({
"barback": "any"
@@ -32,11 +32,11 @@ main() {
integration("pub's implicit constraint uses the same source and "
"description as a dependency override", () {
- servePackages([
- packageMap("barback", current("barback")),
- packageMap("stack_trace", nextPatch("stack_trace")),
- packageMap("source_span", current("source_span"))
- ]);
+ servePackages((builder) {
+ builder.serve("barback", current("barback"));
+ builder.serve("stack_trace", nextPatch("stack_trace"));
+ builder.serve("source_span", current("source_span"));
+ });
d.dir("stack_trace", [
d.libDir("stack_trace", 'stack_trace ${current("stack_trace")}'),
@@ -64,13 +64,13 @@ main() {
integration("doesn't add a constraint if barback isn't in the package "
"graph", () {
- servePackages([
- packageMap("stack_trace", previous("stack_trace")),
- packageMap("stack_trace", current("stack_trace")),
- packageMap("stack_trace", nextPatch("stack_trace")),
- packageMap("stack_trace", max("stack_trace")),
- packageMap("source_span", current("source_span"))
- ]);
+ servePackages((builder) {
+ builder.serve("stack_trace", previous("stack_trace"));
+ builder.serve("stack_trace", current("stack_trace"));
+ builder.serve("stack_trace", nextPatch("stack_trace"));
+ builder.serve("stack_trace", max("stack_trace"));
+ builder.serve("source_span", current("source_span"));
+ });
d.appDir({
"stack_trace": "any"
@@ -84,12 +84,12 @@ main() {
integration("unlocks if the locked version doesn't meet pub's "
"constraint", () {
- servePackages([
- packageMap("barback", current("barback")),
- packageMap("stack_trace", previous("stack_trace")),
- packageMap("stack_trace", current("stack_trace")),
- packageMap("source_span", current("source_span"))
- ]);
+ servePackages((builder) {
+ builder.serve("barback", current("barback"));
+ builder.serve("stack_trace", previous("stack_trace"));
+ builder.serve("stack_trace", current("stack_trace"));
+ builder.serve("source_span", current("source_span"));
+ });
d.appDir({"barback": "any"}).create();

Powered by Google App Engine
This is Rietveld 408576698