Plumb selection edge points through the compositor

Plumb selection edge points through the compositor

Previously, a rect was used to convey selection bound edge geometry. This
proved confusing and problematic, particularly for non-axis-aligned text.
Instead, start using the bound edge points provided by Blink.

This depends on the Blink change http://codereview.chromium.org/495673003/.

BUG=405666
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291460

[jdduke (slow), 2014-08-20 21:27:28]

aelias@: PTAL. This makes the change we discussed form using rects to a pair of
points to indicate the selection bound edge.

[aelias_OOO_until_Jul13, 2014-08-20 21:41:03]

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_android.cc:780: gfx::RectF
start_rect(params.anchor_rect);
Can you go ahead and change ViewHostMsg_SelectionBounds_Params to points as
well?

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_android.cc:789:
start_bound.edge_bottom = start_rect.bottom_left();
If we have to stay with the rect for some reason, I think bottom_right is better
for rotated cases?  (Not sure if those can happen in this codepath but we should
be consistent when we do use a rect).

[jdduke (slow), 2014-08-20 21:58:44]

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_android.cc:780: gfx::RectF
start_rect(params.anchor_rect);
On 2014/08/20 21:41:03, aelias wrote:
> Can you go ahead and change ViewHostMsg_SelectionBounds_Params to points as
> well?

I could, except there's a good amount of dependent Aura code. As soon as we push
through trchen@'s Blink patch we should no longer need
ViewHostMsg_SelectionBounds_Params when using the TouchSelectionController.

https://codereview.chromium.org/494823002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_android.cc:789:
start_bound.edge_bottom = start_rect.bottom_left();
On 2014/08/20 21:41:03, aelias wrote:
> If we have to stay with the rect for some reason, I think bottom_right is
better
> for rotated cases?  (Not sure if those can happen in this codepath but we
should
> be consistent when we do use a rect).

This code will all be ripped out in https://codereview.chromium.org/359033002/.

[aelias_OOO_until_Jul13, 2014-08-20 22:04:25]

OK, sounds like ViewHostMsg_SelectionBounds_Params is destined for deletion so
no reason to change it.  lgtm

[jdduke (slow), 2014-08-20 22:19:06]

PTAL, thanks.

tsepez@: Security review for content/common/cc_messages.h
jamesr@: Owner review for content/renderer/gpu/render_widget_compositor.cc.

[jamesr, 2014-08-20 22:21:18]

lgtm

[Tom Sepez, 2014-08-20 22:31:17]

lgtm

[jdduke (slow), 2014-08-22 13:09:42]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-08-22 13:10:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/494823002/20001

[commit-bot: I haz the power, 2014-08-22 13:54:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/45166)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50350)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-22 13:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 13:57:56]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jdduke (slow), 2014-08-22 17:59:11]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-08-22 18:00:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/494823002/40001

[commit-bot: I haz the power, 2014-08-22 18:57:49]

Committed patchset #3 (40001) as 291460