DescriptionRevert of Improve error reporting when indexing tab. (patchset #7 of https://codereview.chromium.org/449753002/)
Reason for revert:
This patch broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010
A reland of this must include fixes in:
https://codereview.chromium.org/484353003/
https://codereview.chromium.org/499453002/
TBR=tonyg@chromium.org,kbr@chromium.org,jennyz@chromium.org,achuith@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=405955, 406010
Original issue's description:
> Improve error reporting when indexing tab.
>
> If we created 3 new tabs, and 1 of them crashed, then there
> is no guaranteed that browser.tabs[1] return the correct tab
> object. The tabs list can no longer be trusted in this case. Hence if
> the number of inspectable contexts doesn't match the number
> of expected tabs (based on the number of
> tab_list_backend.New & tab_list_backend.Close calls),
> tab_list_backend's __getitem__ throws a TabCrashException.
>
> BUG=398467
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290974
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291431
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 8 (0 generated)
|