Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 494753003: Revert of Improve error reporting when indexing tab. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve error reporting when indexing tab. (patchset #7 of https://codereview.chromium.org/449753002/) Reason for revert: This patch broke chromeos bot in https://code.google.com/p/chromium/issues/detail?id=406010 A reland of this must include fixes in: https://codereview.chromium.org/484353003/ https://codereview.chromium.org/499453002/ TBR=tonyg@chromium.org,kbr@chromium.org,jennyz@chromium.org,achuith@chromium.org NOTRY=true NOTREECHECKS=true BUG=405955, 406010 Original issue's description: > Improve error reporting when indexing tab. > > If we created 3 new tabs, and 1 of them crashed, then there > is no guaranteed that browser.tabs[1] return the correct tab > object. The tabs list can no longer be trusted in this case. Hence if > the number of inspectable contexts doesn't match the number > of expected tabs (based on the number of > tab_list_backend.New & tab_list_backend.Close calls), > tab_list_backend's __getitem__ throws a TabCrashException. > > BUG=398467 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290974 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -67 lines) Patch
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py View 1 chunk +5 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py View 3 chunks +0 lines, -34 lines 0 comments Download
M tools/telemetry/telemetry/core/browser.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 chunk +0 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nednguyen
Created Revert of Improve error reporting when indexing tab.
6 years, 4 months ago (2014-08-22 16:28:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/494753003/1
6 years, 4 months ago (2014-08-22 16:29:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 16:29:14 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-22 16:29:14 UTC) #4
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 16:31:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/494753003/1
6 years, 4 months ago (2014-08-22 16:35:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 291431
6 years, 4 months ago (2014-08-22 16:42:36 UTC) #7
achuithb
6 years, 4 months ago (2014-08-22 17:24:27 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698