tools/telemetry/telemetry/page/page_runner_unittest.py - Issue 494753003: Revert of Improve error reporting when indexing tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 494753003: Revert of Improve error reporting when indexing tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py

index 8d8485115d212a28130bbc1947d6602403ecfcdb..685be569d62ff59c585e5f86b520204eba758edd 100644

--- a/tools/telemetry/telemetry/page/page_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py

@@ -75,9 +75,6 @@

expectations = test_expectations.TestExpectations()

page1 = page_module.Page('chrome://crash', ps)

ps.pages.append(page1)

- page2 = page_module.Page(

- 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())

- ps.pages.append(page2)

class Test(page_test.PageTest):

def ValidatePage(self, *args):

@@ -89,7 +86,7 @@

SetUpPageRunnerArguments(options)

results = results_options.CreateResults(EmptyMetadataForTest(), options)

page_runner.Run(Test(), ps, expectations, options, results)

- self.assertEquals(1, len(GetSuccessfulPageRuns(results)))

+ self.assertEquals(0, len(GetSuccessfulPageRuns(results)))

self.assertEquals(1, len(results.failures))

def testHandlingOfTestThatRaisesWithNonFatalUnknownExceptions(self):

« no previous file with comments | « tools/telemetry/telemetry/core/tab_unittest.py ('k') | no next file » | no next file with comments »