Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 494483002: Cheat to go fast, but be careful in debug mode. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cheat to go fast, but be careful in debug mode. Turns out recording actual text metrics is currently really slow. If we want to compete with the (cheating) status quo, gotta cheat too. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a19afb418027800c245ad19d651d8cf2071c9d70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 4 months ago (2014-08-19 22:52:05 UTC) #1
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-19 22:52:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/494483002/1
6 years, 4 months ago (2014-08-19 22:52:43 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-19 22:52:43 UTC) #4
reed1
lgtm
6 years, 4 months ago (2014-08-20 00:45:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as a19afb418027800c245ad19d651d8cf2071c9d70
6 years, 4 months ago (2014-08-20 00:47:20 UTC) #6
robertphillips
Do we have any idea why getFontMetrics is so slow (I thought we were caching ...
6 years, 4 months ago (2014-08-20 13:04:21 UTC) #7
reed1
6 years, 4 months ago (2014-08-20 13:34:01 UTC) #8
Message was sent while issue was closed.
On 2014/08/20 13:04:21, robertphillips wrote:
> Do we have any idea why getFontMetrics is so slow (I thought we were caching
the
> answers so the expensive parts would be amortized away)?

It is slow because we have to get into the font cache (via a mutex), find the
right entry, and get out.

Powered by Google App Engine
This is Rietveld 408576698