Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: src/core/SkRecordDraw.cpp

Issue 494483002: Cheat to go fast, but be careful in debug mode. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkRecordDraw.cpp
diff --git a/src/core/SkRecordDraw.cpp b/src/core/SkRecordDraw.cpp
index e792d3714305ba2ee4b33e33a4e87c50fcf1e19e..613c2c0dd4e759fff874a54a1e08ca8e357e3b3a 100644
--- a/src/core/SkRecordDraw.cpp
+++ b/src/core/SkRecordDraw.cpp
@@ -312,15 +312,23 @@ private:
}
static void AdjustTextForFontMetrics(SkRect* rect, const SkPaint& paint) {
- // FIXME: These bounds should be tight (and correct), but reading SkFontMetrics is likely
- // a performance bottleneck. It's safe to overapproximate these metrics for speed. E.g.
- // fTop <= 1.5 * paint.getTextSize(), fXMax <= 8 * fTop, etc.
+#if SK_DEBUG
+ SkRect correct = *rect;
+#endif
+ const SkScalar yPad = 1.5f * paint.getTextSize(), // In practice, this seems to be enough.
+ xPad = 4.0f * yPad; // Hack for very wide Github logo font.
+ rect->outset(xPad, yPad);
+#if SK_DEBUG
SkPaint::FontMetrics metrics;
paint.getFontMetrics(&metrics);
- rect->fLeft += metrics.fXMin;
- rect->fTop += metrics.fTop;
- rect->fRight += metrics.fXMax;
- rect->fBottom += metrics.fBottom;
+ correct.fLeft += metrics.fXMin;
+ correct.fTop += metrics.fTop;
+ correct.fRight += metrics.fXMax;
+ correct.fBottom += metrics.fBottom;
+ SkASSERTF(rect->contains(correct), "%f %f %f %f vs. %f %f %f %f\n",
+ -xPad, -yPad, +xPad, +yPad,
+ metrics.fXMin, metrics.fTop, metrics.fXMax, metrics.fBottom);
+#endif
}
// Returns true if rect was meaningfully adjusted for the effects of paint,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698