Append "Callback" to each value of enum CallbackType

Append "Callback" to each value of enum CallbackType

Append Callback to values enum CallBackType to have more meaning
in the enum. Also, it has been renamed in specs.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181013

[deepak.sa, 2014-08-22 13:44:39]

PTAL?
Thanks!

[dominicc (has gone to gerrit), 2014-08-25 01:05:18]

On 2014/08/22 13:44:39, deepak.sa wrote:
> PTAL?
> Thanks!

Not LGTM.

These names were chosen to match the terms in the Custom Elements spec.

The type name also has "Callbacks" in it. So ...Callbacks::...Callback seems
redundant.

[deepak.sa, 2014-08-25 07:32:21]

On 2014/08/25 01:05:18, dominicc (vacation to 8.25) wrote:
> On 2014/08/22 13:44:39, deepak.sa wrote:
> > PTAL?
> > Thanks!
> 
> Not LGTM.
> 
> These names were chosen to match the terms in the Custom Elements spec.
> 
> The type name also has "Callbacks" in it. So ...Callbacks::...Callback seems
> redundant.

In latest editor's draft:
http://w3c.github.io/webcomponents/spec/custom/#dfn-created-callback
callbacks has been renamed to add "Callback" .

As for redundancy, IMHO, it adds a bit more clarification to the naming of
callbacks.

[esprehn, 2014-08-26 08:46:27]

Given that the spec renamed this too, I think this is a good change.

[dominicc (has gone to gerrit), 2014-08-26 14:03:06]

On 2014/08/26 08:46:27, esprehn wrote:
> Given that the spec renamed this too, I think this is a good change.

Makes sense. Consistency with the spec is good. LGTM.

[dominicc (has gone to gerrit), 2014-08-26 14:03:12]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2014-08-26 14:04:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/494133002/1

[deepak.sa, 2014-08-26 14:08:16]

@esprehn
bindings/ required.

[commit-bot: I haz the power, 2014-08-26 14:54:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[commit-bot: I haz the power, 2014-08-26 14:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 14:56:53]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[deepak.sa, 2014-08-28 04:30:47]

Ping!
bindings/ required.

[deepak.sa, 2014-08-28 04:45:42]

deepak.sa@samsung.com changed reviewers:
+ haraken@chromium.org

[deepak.sa, 2014-08-28 04:45:42]

+haraken
Could you please review?
Thanks!

[haraken, 2014-08-28 04:49:26]

LGTM

[deepak.sa, 2014-08-28 04:58:42]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-08-28 04:59:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/494133002/1

[commit-bot: I haz the power, 2014-08-28 05:04:54]

Committed patchset #1 (id:1) as 181013